Fix development server not working in Laravel 9. #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest waiting on laravel/framework#40954 before deciding whether to merge this. |
|
I also would like to wait for a fix on the Laravel side - but either way I'm off until next monday so I can't merge this yet anyway |
|
A fix has been added on Laravel side, hence I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel 9 adds a default connection timeout to the Http client, making the usage of
connect_timeoutinHttp::withOptionscalls to cause an exception when the options reach guzzle.This is due to
withOptionsusingarray_merge_recursiveto merge the options, causing existing options to be arrayed.This PR fixes it by using the
connectTimeoutmethod added in Laravel 9.