Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double the sleep delay in IdempotentFunctionIntegrationTest #85

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Double the sleep delay in IdempotentFunctionIntegrationTest #85

merged 1 commit into from
Sep 12, 2024

Conversation

KiKoS0
Copy link
Collaborator

@KiKoS0 KiKoS0 commented Sep 12, 2024

Summary

Hopefully that it's less likely that tests fail due to hitting:

demo:integrationTest > Executing test com.inngest.spring
IdempotentFunctionIntegrationTest > testIdempotencyKey() FAILED
    java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0
        at com.inngest.springbootdemo.EventRunsResponse.first(EventRunsResponse.java:14)
        at com.inngest.springbootdemo.IdempotentFunctionIntegrationTest.testIdempotencyKey(IdempotentFunctionIntegrationTest.java:33)

Checklist

  • Update documentation
  • Added unit/integration tests

@KiKoS0 KiKoS0 self-assigned this Sep 12, 2024
albertchae
albertchae approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@albertchae albertchae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@albertchae albertchae merged commit befe29b into main Sep 12, 2024
8 of 9 checks passed
@albertchae albertchae deleted the riadh/increase-sleep-delay-in-test branch September 12, 2024 03:16
@KiKoS0 KiKoS0 mentioned this pull request Sep 12, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertchae albertchae albertchae approved these changes

@djfarrelly djfarrelly Awaiting requested review from djfarrelly djfarrelly is a code owner

@darwin67 darwin67 Awaiting requested review from darwin67 darwin67 is a code owner

@jpwilliams jpwilliams Awaiting requested review from jpwilliams jpwilliams is a code owner

@tonyhb tonyhb Awaiting requested review from tonyhb tonyhb is a code owner

Assignees

@KiKoS0 KiKoS0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KiKoS0 @albertchae