Address PR feedback

inngest · Sep 13, 2024 · 1822df5 · 1822df5
1 parent c2804ef
commit 1822df5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/inngest-spring-boot-adapter/src/main/java/com/inngest/springboot/InngestController.java b/inngest-spring-boot-adapter/src/main/java/com/inngest/springboot/InngestController.java
@@ -31,7 +31,6 @@ private HttpHeaders getHeaders() {
     @GetMapping
     public ResponseEntity<String> index(
         @RequestHeader(HttpHeaders.HOST) String hostHeader,
-        HttpServletRequest request,
         @RequestHeader(name = "X-Inngest-Signature", required = false) String signature,
         @RequestHeader(name = "X-Inngest-Server-Kind", required = false) String serverKind
     ) {

diff --git a/inngest-spring-boot-demo/build.gradle.kts b/inngest-spring-boot-demo/build.gradle.kts
@@ -47,6 +47,8 @@ tasks.withType<Test> {
     systemProperty("junit.jupiter.execution.parallel.enabled", true)
     systemProperty("test-group", "unit-test")
 
+    // Required by `system-stubs-jupiter` for JDK 21+ compatibility
+    // https://github.com/raphw/byte-buddy/issues/1396
     jvmArgs = listOf("-Dnet.bytebuddy.experimental=true")
     testLogging {
         events =

diff --git a/inngest/src/main/kotlin/com/inngest/ServeConfig.kt b/inngest/src/main/kotlin/com/inngest/ServeConfig.kt
@@ -33,7 +33,13 @@ class ServeConfig
             }
         }
 
-        fun hasSigningKey() = signingKey() !in listOf(DUMMY_SIGNING_KEY, "")
+        fun hasSigningKey() {
+            when (signingKey()) {
+                DUMMY_SIGNING_KEY -> false
+                "" -> false
+                else -> true
+            }
+        }
 
         fun baseUrl(): String {
             if (baseUrl != null) return baseUrl