Issue/8294 strip more #8320
Closed
Issue/8294 strip more #8320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hugo-Inmanta
requested changes
Nov 6, 2024
tests/test_cli.py
Outdated
|
|
||
| result = await cli.run("monitor", "-e", environment) | ||
| assert result.exit_code == 0 | ||
| print(result.output) |
There was a problem hiding this comment.
Should be removed or asserted vs an expected output probably
There was a problem hiding this comment.
it is hard to assert anything usefull, because the progress bar updates the output, so when the test is done, there is not much to see.
I'll remove it
src/inmanta/main.py
Outdated
Comment on lines
814
to
815
| # {'by_state': {'available': 3, 'cancelled': 0, 'deployed': 12, 'deploying': 0, 'failed': 0, 'skipped': 0, | ||
| # 'skipped_for_undefined': 0, 'unavailable': 0, 'undefined': 0}, 'total': 15} |
There was a problem hiding this comment.
This doesn't feel right at a glance, probably only relevant for the resource container in tests
There was a problem hiding this comment.
You mean the comment? I'll remove it
Co-authored-by: Hugo-Inmanta <[email protected]>
…re into issue/8294_strip_more
Hugo-Inmanta
reviewed
Nov 6, 2024
Hugo-Inmanta
approved these changes
Nov 6, 2024
arnaudsjs
requested changes
Nov 6, 2024
| @@ -1027,10 +1018,6 @@ def convert_legacy_state( | |||
|
|
|||
| def post_deploy_update() -> None: | |||
| assert model_version is not None # mypy can't figure this out | |||
| # Make sure tasks are scheduled AFTER the tx is done. | |||
There was a problem hiding this comment.
I think we can remove the assertion as wel.
tests/conftest.py
Outdated
Comment on lines
2526
to
2540
| result = await client.resource_list(env_id, deploy_summary=True) | ||
| assert result.code == 200 | ||
| summary = result.result["metadata"]["deploy_summary"] | ||
| # {'by_state': {'available': 3, 'cancelled': 0, 'deployed': 12, 'deploying': 0, 'failed': 0, 'skipped': 0, | ||
| # 'skipped_for_undefined': 0, 'unavailable': 0, 'undefined': 0}, 'total': 15} | ||
| total: int = summary["total"] | ||
|
|
||
| done = ( | ||
| summary["by_state"]["deployed"] | ||
| + summary["by_state"]["failed"] | ||
| + summary["by_state"]["skipped"] | ||
| + summary["by_state"]["skipped_for_undefined"] | ||
| + summary["by_state"]["unavailable"] | ||
| + summary["by_state"]["undefined"] | ||
| ) |
There was a problem hiding this comment.
Shouldn't we isolate this logic into a method. It's used twice in this method.
Co-authored-by: arnaudsjs <[email protected]>
arnaudsjs
approved these changes
Nov 7, 2024
|
Processing this pull request |
|
Merged into branches master in c595ef6 |
inmantaci
pushed a commit
that referenced
this pull request
Nov 7, 2024
… PR #8320) # Description Strip version and status closes #8252 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [X] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Strip version and status
closes #8252
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the box