-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump build from 0.10.0 to 1.0.0 #6450
Conversation
Bumps [build](https://github.com/pypa/build) from 0.10.0 to 1.0.0. - [Release notes](https://github.com/pypa/build/releases) - [Changelog](https://github.com/pypa/build/blob/main/CHANGELOG.rst) - [Commits](pypa/build@0.10.0...1.0.0) --- updated-dependencies: - dependency-name: build dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
@wouterdb I think the actual implementation change is pretty simple and 1 reviewer suffices there. I'm adding you mostly to review the bumped lower bound on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have little pertinent knowledge on this, so I approve
src/inmanta/moduletool.py
Outdated
@@ -46,11 +45,11 @@ | |||
from pkg_resources import Requirement, parse_version | |||
|
|||
import build | |||
import build as build_module # additionaly import as an alias for use in contexts with a name clash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This I don't understand? why not import it once with the build_module alias and use build_module everywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly because I have a strong aversion to it. Would you prefer it like that? I must confess I have an aversion to the approach I took as well, just less so than the alternative. But I am definitely not too attached to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why you don't like using the alias everywhere? I think I prefer having the same name everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transparency mostly: I prefer to refer to modules by their name. Especially considering there are subimports. Perhaps I should just go back to non-qualified imports. Also less transparent, but at least it's consistent and unambiguous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Processing this pull request |
Merged into branches iso6 in dcea46d |
Bumps [build](https://github.com/pypa/build) from 0.10.0 to 1.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pypa/build/releases">build's releases</a>.</em></p> <blockquote> <h2>1.0.0</h2> <h2>What's Changed</h2> <ul> <li>infra: replace flake8 with ruff by <a href="https://github.com/layday"><code>@layday</code></a> in <a href="https://redirect.github.com/pypa/build/pull/565">pypa/build#565</a></li> <li>Refactor <code>IsolatedEnv</code>, take two by <a href="https://github.com/layday"><code>@layday</code></a> in <a href="https://redirect.github.com/pypa/build/pull/537">pypa/build#537</a></li> <li>util: allow passing alternative runner to <code>project_wheel_metadata</code> by <a href="https://github.com/q0w"><code>@q0w</code></a> in <a href="https://redirect.github.com/pypa/build/pull/566">pypa/build#566</a></li> <li>ci: do not trigger workflow for RST file changes by <a href="https://github.com/layday"><code>@layday</code></a> in <a href="https://redirect.github.com/pypa/build/pull/568">pypa/build#568</a></li> <li>build: drop toml fallback by <a href="https://github.com/layday"><code>@layday</code></a> in <a href="https://redirect.github.com/pypa/build/pull/567">pypa/build#567</a></li> <li>infra: fix ruff configuration and add a few checks by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/573">pypa/build#573</a></li> <li>Minor doc fixes by <a href="https://github.com/layday"><code>@layday</code></a> in <a href="https://redirect.github.com/pypa/build/pull/574">pypa/build#574</a></li> <li>docs: reorder installation instructions by <a href="https://github.com/hauntsaninja"><code>@hauntsaninja</code></a> in <a href="https://redirect.github.com/pypa/build/pull/575">pypa/build#575</a></li> <li>Specify encoding by <a href="https://github.com/jaraco"><code>@jaraco</code></a> in <a href="https://redirect.github.com/pypa/build/pull/578">pypa/build#578</a></li> <li>infra: use latest Ruff instead of isort by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/581">pypa/build#581</a></li> <li>tests: report installed versions of common packages by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/588">pypa/build#588</a></li> <li>tests: strip formatting from stderr (pip 23) by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/589">pypa/build#589</a></li> <li>docs: remove direct references to PEP 517 in docs landing page by <a href="https://github.com/pradyunsg"><code>@pradyunsg</code></a> in <a href="https://redirect.github.com/pypa/build/pull/562">pypa/build#562</a></li> <li>docs: use sphinx-issues by <a href="https://github.com/FFY00"><code>@FFY00</code></a> in <a href="https://redirect.github.com/pypa/build/pull/590">pypa/build#590</a></li> <li>config: support running Ruff 0.258+ directly on source by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/591">pypa/build#591</a></li> <li>tests: useless .stdout detected by Ruff PR by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/594">pypa/build#594</a></li> <li>Fix link to installation page in docs by <a href="https://github.com/atugushev"><code>@atugushev</code></a> in <a href="https://redirect.github.com/pypa/build/pull/597">pypa/build#597</a></li> <li>fix: mypy update by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/606">pypa/build#606</a></li> <li>chore: minor cleanup by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/605">pypa/build#605</a></li> <li>chore: isort Ruff code was missing by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/604">pypa/build#604</a></li> <li>🎨🧪 Modularize GHA workflow through reuse by <a href="https://github.com/webknjaz"><code>@webknjaz</code></a> in <a href="https://redirect.github.com/pypa/build/pull/618">pypa/build#618</a></li> <li>Improve CLI help text by <a href="https://github.com/layday"><code>@layday</code></a> in <a href="https://redirect.github.com/pypa/build/pull/616">pypa/build#616</a></li> <li>ci: add 3.12 beta testing by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/624">pypa/build#624</a></li> <li>chore: remove unneeded target-version by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/634">pypa/build#634</a></li> <li>pre-commit: ruff moved to astral-sh by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/635">pypa/build#635</a></li> <li>main: filter out malicious files when extracting tar archives by <a href="https://github.com/layday"><code>@layday</code></a> in <a href="https://redirect.github.com/pypa/build/pull/609">pypa/build#609</a></li> <li>main: avoid cost of importing virtualenv if not using it by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/636">pypa/build#636</a></li> <li>Bump importlib metadata dependency by <a href="https://github.com/jaraco"><code>@jaraco</code></a> in <a href="https://redirect.github.com/pypa/build/pull/631">pypa/build#631</a></li> <li>main: ensure config_settings are passed to get_requires_for_build by <a href="https://github.com/jameshilliard"><code>@jameshilliard</code></a> in <a href="https://redirect.github.com/pypa/build/pull/627">pypa/build#627</a></li> <li>tests: add network marker by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/649">pypa/build#649</a></li> <li>chore: use 2x faster black mirror by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/652">pypa/build#652</a></li> <li>docs: bump furo/sphinx by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/660">pypa/build#660</a></li> <li>readme: touch up badge by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/659">pypa/build#659</a></li> <li>fix: include all files in SDist by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/657">pypa/build#657</a></li> <li>fix: tests & file inclusion update by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/661">pypa/build#661</a></li> <li>chore: add some exception handling minor cleanup checks by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/662">pypa/build#662</a></li> <li>docs: update changelog for 0.11.0 by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/664">pypa/build#664</a></li> <li>Release 1.0.0 by <a href="https://github.com/gaborbernat"><code>@gaborbernat</code></a> in <a href="https://redirect.github.com/pypa/build/pull/668">pypa/build#668</a></li> <li>ci: build and test SDist/wheels by <a href="https://github.com/henryiii"><code>@henryiii</code></a> in <a href="https://redirect.github.com/pypa/build/pull/669">pypa/build#669</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/q0w"><code>@q0w</code></a> made their first contribution in <a href="https://redirect.github.com/pypa/build/pull/566">pypa/build#566</a></li> <li><a href="https://github.com/atugushev"><code>@atugushev</code></a> made their first contribution in <a href="https://redirect.github.com/pypa/build/pull/597">pypa/build#597</a></li> <li><a href="https://github.com/jameshilliard"><code>@jameshilliard</code></a> made their first contribution in <a href="https://redirect.github.com/pypa/build/pull/627">pypa/build#627</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/pypa/build/compare/0.10.0...1.0.0">https://github.com/pypa/build/compare/0.10.0...1.0.0</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/build/blob/main/CHANGELOG.rst">build's changelog</a>.</em></p> <blockquote> <h1>1.0.0 (2023-09-01)</h1> <ul> <li>Removed the <code>toml</code> library fallback; <code>toml</code> can no longer be used as a substitute for <code>tomli</code> (PR :pr:<code>567</code>)</li> <li>Added <code>runner</code> parameter to <code>util.project_wheel_metadata</code> (PR :pr:<code>566</code>, fixes issue :issue:<code>553</code>)</li> <li>Modified <code>ProjectBuilder</code> constructor signature, added alternative <code>ProjectBuilder.from_env</code> constructor, redefined <code>env.IsolatedEnv</code> interface, and exposed <code>env.DefaultIsolatedEnv</code>, replacing <code>env.IsolatedEnvBuilder</code>. The aim has been to shift responsibility for modifying the environment from the project builder to the <code>IsolatedEnv</code> entirely and to ensure that the builder will be initialised from an <code>IsolatedEnv</code> in a consistent manner. Mutating the project builder is no longer supported. (PR :pr:<code>537</code>)</li> <li><code>virtualenv</code> is no longer imported when using <code>-n</code>, for faster builds (PR :pr:<code>636</code>, fixes issue :issue:<code>510</code>)</li> <li>The SDist now contains the repository contents, including tests. Flit-core 3.8+ required. (PR :pr:<code>657</code>, :pr:<code>661</code>, fixes issue :issue:<code>656</code>)</li> <li>The minimum version of <code>importlib-metadata</code> has been increased to 4.6 and Python 3.10 due to a bug in the standard library version with URL requirements in extras. This is still not required for 3.8 when bootstrapping (as long as you don't have URL requirements in extras). (PR :pr:<code>631</code>, fixes issue :issue:<code>631</code>)</li> <li>Docs now built with Sphinx 7 (PR :pr:<code>660</code>)</li> <li>Tests now contain a <code>network</code> marker (PR :pr:<code>649</code>, fixes issue :issue:<code>648</code>)</li> <li>Config-settings are now passed to <code>get_requires*</code> hooks, fixing a long standing bug. If this affects your setuptools build, you can use <code>-C--build-option=<cmd> -C--build-option=<option></code> to workaround an issue with Setuptools not allowing unrecognised build options when running this hook. (PR :pr:<code>627</code>, fixes issue :issue:<code>[#264](https://github.com/pypa/build/issues/264)</code>)</li> <li>Test on Python 3.12 betas/RCs (PR :pr:<code>624</code>)</li> <li>Filter out malicious files when extracting tar archives when Python supports it (PR :pr:<code>609</code>)</li> <li>Specify encoding, fixing issues when <code>PYTHONWARNDEFAULTENCODING</code> is set. (PR :pr:<code>587</code>, fixes issue :issue:<code>577</code>)</li> <li>Ruff is now used for linting.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/build/commit/1fff01ed7440d5b5626fec31422026a4920b7764"><code>1fff01e</code></a> style: ignore W005, since we are build</li> <li><a href="https://github.com/pypa/build/commit/06e0481cee5321c3a755fd1675e15c3fa926d201"><code>06e0481</code></a> ci: build and test SDist/wheels</li> <li><a href="https://github.com/pypa/build/commit/ed308f1f4507182d8c0f67ee6ca288b6d73b1270"><code>ed308f1</code></a> Release 1.0.0</li> <li><a href="https://github.com/pypa/build/commit/5e35bee312980b297c438614bc08b479f906e460"><code>5e35bee</code></a> Update pyproject.toml</li> <li><a href="https://github.com/pypa/build/commit/d73f9067dac645816472d9cf4e14155a8eff9d46"><code>d73f906</code></a> Update pyproject.toml</li> <li><a href="https://github.com/pypa/build/commit/cabf511810d32df3012a28d7daa3b80e4a87f62a"><code>cabf511</code></a> Update CHANGELOG.rst</li> <li><a href="https://github.com/pypa/build/commit/bd0176b8ebe7ed2ce0d19e8e3a1646895dd1e8e7"><code>bd0176b</code></a> ci: include pyproject.toml for test changes</li> <li><a href="https://github.com/pypa/build/commit/57d5af5eaf469f63801366510427ba03fd15f3cd"><code>57d5af5</code></a> docs: update changelog for 0.11.0</li> <li><a href="https://github.com/pypa/build/commit/fa419f2d0835c0550f99d6403ea63eeab49a3839"><code>fa419f2</code></a> pre-commit: bump repositories</li> <li><a href="https://github.com/pypa/build/commit/59c1f87503914d04b634db3633d7189e8627e65b"><code>59c1f87</code></a> chore: add some exception handling minor cleanup checks</li> <li>Additional commits viewable in <a href="https://github.com/pypa/build/compare/0.10.0...1.0.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=build&package-manager=pip&previous-version=0.10.0&new-version=1.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps build from 0.10.0 to 1.0.0.
Release notes
Sourced from build's releases.
Changelog
Sourced from build's changelog.
Commits
1fff01e
style: ignore W005, since we are build06e0481
ci: build and test SDist/wheelsed308f1
Release 1.0.05e35bee
Update pyproject.tomld73f906
Update pyproject.tomlcabf511
Update CHANGELOG.rstbd0176b
ci: include pyproject.toml for test changes57d5af5
docs: update changelog for 0.11.0fa419f2
pre-commit: bump repositories59c1f87
chore: add some exception handling minor cleanup checksDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)