Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: remove invalid feedback types and add missing ones #234

Open
wants to merge 1 commit into
base: feat-feedback-expires-at
Choose a base branch
from
Open

fix!: remove invalid feedback types and add missing ones #234

wants to merge 1 commit into from

Conversation

figueredo
Copy link
Contributor

@figueredo figueredo commented Jul 17, 2024 •
edited
Loading

Proposed changes

Removes no longer valid feedback types and add missing ones, according to public docs.

This is a breaking change.

Checklist

  • Style check and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@figueredo figueredo requested a review from racevedoo July 17, 2024 18:12
@figueredo figueredo self-assigned this Jul 17, 2024
@figueredo figueredo requested a review from a team as a code owner July 17, 2024 18:12
@figueredo figueredo requested review from b0rba and removed request for a team July 17, 2024 18:12
@figueredo figueredo force-pushed the fix-feedback-remove-invalid-types branch 2 times, most recently from ae0e4e4 to 0be2276 Compare July 19, 2024 20:16
@figueredo figueredo changed the base branch from rfc3339-fields to feat-feedback-expires-at July 19, 2024 20:17
@figueredo figueredo force-pushed the fix-feedback-remove-invalid-types branch from 0be2276 to 6a11b1d Compare July 20, 2024 04:11
@figueredo figueredo force-pushed the fix-feedback-remove-invalid-types branch from 6a11b1d to 15214b1 Compare July 20, 2024 04:21
@figueredo figueredo force-pushed the fix-feedback-remove-invalid-types branch from 15214b1 to 9b5b214 Compare July 24, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racevedoo racevedoo racevedoo approved these changes

@b0rba b0rba Awaiting requested review from b0rba b0rba is a code owner automatically assigned from inloco/incognia-owners

Assignees

@figueredo figueredo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@figueredo @racevedoo