Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added the Buffer case #18

Merged
merged 4 commits into from
May 24, 2021
Merged

fix: added the Buffer case #18

merged 4 commits into from
May 24, 2021

Conversation

Farfurix
Copy link
Contributor

@Farfurix Farfurix commented May 20, 2021 •
edited
Loading

Changes

  1. Added the Buffer case.
  2. Updated mocha (fixed nested vulnerable dependency).
  3. Temporarily switch off the vulnerable check (because of the publish-please dependency).
  4. Bumped a version.
  5. Used the "typeof" check directly to avoid the "is not defined" reference error.
  6. TYPED_ARRAY_CTORS is overwritten to avoid possible ReferenceError issues.

@AndreyBelym AndreyBelym merged commit c0ebc6e into inikulin:master May 24, 2021
@Farfurix Farfurix deleted the buffer-case branch May 24, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyBelym AndreyBelym AndreyBelym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Farfurix @AndreyBelym