Skip to content

Commit

Permalink
PS-6751 - innodb.table_encrypt_debug is failing
Browse files Browse the repository at this point in the history
This is a regression introduced by PS-5325 at [1]. A few tests were
missing add_suppression on new warnings thrown by the fix.

[1]:

commit 1daddaf
Author: Marcelo Altmann <[email protected]>
Date:   Wed Jul 17 08:54:28 2019 -0300

    PS-5325 Conditional jump or move depends on uninitialised value on innodb_zip.wl5522_zip and innodb.alter_missing_tablespace

    Problem:
    As part of DISCARD TABLESPACE, MySQL deinitialize table statistics.
    Later if we need to access the table (MySQL allows DDL)
    those variables won't have been initialized again. This is a regression
    introduced by PS-3829 at [1].

    Solution:
    Call dict_stats_init even if the table has been discarded.
    This will result in dict_stats_report_error been called, which as
    part of the error handling will init empty table statistics.
    As part of the fix, we need to suppress warnings that will be generated
    by dict_stats_report_error on related tests.
  • Loading branch information
altmannmarcelo committed Jan 3, 2020
1 parent b90d9b1 commit 339c6c6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions mysql-test/include/table_encrypt_debug.inc
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ call mtr.add_suppression("Cannot open table tde_db/.* from the internal data dic
call mtr.add_suppression("\\[Warning\\] InnoDB: Tablespace for table `tde_db`.`t1` is set as discarded");
call mtr.add_suppression("\\[ERROR\\] InnoDB: The table .* doesn't have a corresponding tablespace, it was discarded.");
call mtr.add_suppression("\\[Warning\\] InnoDB: Cannot calculate statistics for table .* because the \.ibd file is missing");
call mtr.add_suppression("InnoDB: Trying to access missing tablespace [0-9]+");
call mtr.add_suppression("\\[Warning\\] InnoDB: Cannot save statistics for table .* because the \.ibd file is missing");
--enable_query_log

let $innodb_file_per_table = `SELECT @@innodb_file_per_table`;
Expand Down

0 comments on commit 339c6c6

Please sign in to comment.