-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement initial version #2
Open
acoulton
wants to merge
34
commits into
main
Choose a base branch
from
initial-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For where you want to opt-out of all the automatic logic and do your own thing completely.
Use a list of guessers so that we can easily add support for more in future without having to alter the code in other things.
`false` is a clearer return when we are saying we explicitly don't know what provider to use.
As we are going to need different attributes for hydration and I don't want to confuse them.
The dates are the easy ones (so that tests can give just a simple string). This will also be how we do collections etc.
We can simplify to two distinct sets of concerns: * StubAs -> cast the value to the expected type * StubDefault -> generate a default value
`(new StubObjects)->stub()` will be the main entry point. The individual internal factories then follow `StubFactory` naming.
So that we only have to do the parsing for the first of a type, and then are just passing values through the predefined chain.
When you have classes that have some internal logic that needs to be bypassed - generally e.g. if they directly reference an external dependency such as the filesystem etc.
Will give us a lot more control over the interface in future, and make it easier for users to understand how to implement it.
This is ambiguous - do you mean "now" (which is how PHP will interpret it) or "null"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.