Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed infinite loop on progress indicator on max < min #2033

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: fixed infinite loop on progress indicator on max < min #2033

wants to merge 4 commits into from

Conversation

NeelSinha
Copy link

@NeelSinha NeelSinha commented Jul 6, 2023 •
edited
Loading

What I did

  1. Added a check for max < min on updated lifecycle of progress indicator, throws an error.

What does it fix

  1. If you set max lesser than min, it goes to infinite loop and the page breaks, this change prevents that.

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d24cc19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jorenbroekema
jorenbroekema requested changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@jorenbroekema jorenbroekema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for more descriptive error message.

Can you also add a test showing the scenario and the fact that it will throw in this case?

packages/ui/components/progress-indicator/src/LionProgressIndicator.js Outdated Show resolved Hide resolved
@gerjanvangeest gerjanvangeest added enhancement New feature or request help wanted Extra attention is needed labels Oct 4, 2023
@gerjanvangeest
Copy link
Member

This PR still needs some attention, maybe we can bring it back to live and finalise it soon!
Anybody lending a hand, feel free 💪!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorenbroekema jorenbroekema jorenbroekema requested changes

@tlouisse tlouisse Awaiting requested review from tlouisse tlouisse is a code owner

@daKmoR daKmoR Awaiting requested review from daKmoR

@gerjanvangeest gerjanvangeest Awaiting requested review from gerjanvangeest gerjanvangeest is a code owner

@erikkroes erikkroes Awaiting requested review from erikkroes

@ruphin ruphin Awaiting requested review from ruphin

@narzac narzac Awaiting requested review from narzac narzac is a code owner

@Knorgias Knorgias Awaiting requested review from Knorgias Knorgias is a code owner

@whenlit whenlit Awaiting requested review from whenlit

@DannyMoerkerke DannyMoerkerke Awaiting requested review from DannyMoerkerke

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NeelSinha @CLAassistant @gerjanvangeest @jorenbroekema @NeerajSinhaJioDSDev