Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for connecting to Cassandra DBaaS cluster with secure connect bundle #2

Merged
merged 1 commit into from
May 20, 2021

Conversation

msmygit
Copy link
Contributor

@msmygit msmygit commented May 11, 2021

Assist with #1 by providing the initial changes required to connect to the Apache Cassandra(R) DBaaS cluster.

@msmygit
Copy link
Contributor Author

msmygit commented May 12, 2021

@maximevw will you please review this at your convenience? Thank you in advance!

Copy link
Collaborator

@maximevw maximevw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @msmygit for your contribution. After review, I suggested few changes into your pull request.

As you mentioned in #1, this is a good code base to support connections to Cassandra DBaaS offering and we'll have to think how to manage the connection string to make it clearer in a such use case, especially to avoid specifying a fake host/port.

src/main/java/com/ing/data/cassandra/jdbc/Utils.java Outdated Show resolved Hide resolved
src/main/java/com/ing/data/cassandra/jdbc/Utils.java Outdated Show resolved Hide resolved
src/main/java/com/ing/data/cassandra/jdbc/Utils.java Outdated Show resolved Hide resolved
…onnect to the Apache Cassandra(R) DBaaS cluster
Copy link
Collaborator

@maximevw maximevw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @msmygit for your contribution and do not hesitate to contribute again in the future if you have interesting ideas to improve this wrapper.

@maximevw maximevw merged commit 1f87958 into ing-bank:release/next May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants