improve: include the server TLS CA in the chain #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
requested review from
BruceMacD,
jmorganca,
pdevine and
kimskimchi
as code owners
dnephin
commented
Jun 30, 2022
Comment on lines
+625
to
+597
| title := "Certificate" | ||
| if cert.IsCA { | ||
| title = "Certificate Authority" |
There was a problem hiding this comment.
I pushed this one more small change. To indicate in the prompt if the user is trusting a leaf cert or a CA.
dnephin
force-pushed
the
dnephin/server-tls-config-2
branch
from
e10b58f to
2a51a80
Compare
dnephin
force-pushed
the
dnephin/server-tls-config-3
branch
from
a7b1704 to
865bd5a
Compare
dnephin
force-pushed
the
dnephin/server-tls-config-2
branch
from
2a51a80 to
8d63f54
Compare
dnephin
force-pushed
the
dnephin/server-tls-config-3
branch
from
865bd5a to
072d8a3
Compare
dnephin
force-pushed
the
dnephin/server-tls-config-2
branch
from
8d63f54 to
4dc9598
Compare
So that the client can trust the CA instead of the leaf cert.
To say Certificate Authority if the cert is a CA
dnephin
force-pushed
the
dnephin/server-tls-config-3
branch
from
072d8a3 to
a56d37a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Branched from #2401
This ended up being easier than I thought. By adding the CA cert to the chain returned by the server the client side error already has the right cert. Also log the CA fingerprint in the server on startup so that it is visible in logs.
Resolves #2362