server: print sha256 fingerprint of TLS cert to server logs #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This log message will only be printed once, when the cert is first generated. After that someone can produce the fingerprint use openssl as long as they have access to the PEM file, using: openssl x509 -noout -fingerprint -sha256 -inform pem -in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This log message will only be printed once, when the cert is first generated. It would be nice to have it printed on every restart, but the way our TLS config is setup right now that is difficult. Maybe we'll be able to fix that as part of #2176 or #2067, which will involve some work in this area.
After the initial cert generation someone with access to the certificate can produce the fingerprint using
openssl:The certificate is stored in a file in the directory specified by the
tlsCacheserver option.This fingerprint will be used in #2177, for #1541.
I extracted a couple functions that I expect to use in #2177, but I've left them unexported for now.