forked from kubeshop/testkube
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for user provided plugins #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parauliya
force-pushed
the
plugins-support
branch
from
August 29, 2023 08:55
dae2d4e
to
d46049b
Compare
hiteshwani
force-pushed
the
plugins-support
branch
from
August 30, 2023 04:14
24eacaf
to
d9e0056
Compare
Also. let's update the PR description please. |
Signed-off-by: hiteshwani <[email protected]>
Signed-off-by: hiteshwani <[email protected]>
hiteshwani
force-pushed
the
plugins-support
branch
from
August 31, 2023 10:08
d9e0056
to
3c5de0e
Compare
Signed-off-by: Aman Parauliya <[email protected]>
Signed-off-by: hiteshwani <[email protected]>
Signed-off-by: hiteshwani <[email protected]>
parauliya
force-pushed
the
plugins-support
branch
from
August 31, 2023 10:17
3c5de0e
to
a095f73
Compare
…kube into plugins-support
…kube into plugins-support
hiteshwani
added a commit
that referenced
this pull request
Sep 15, 2023
* feat: Initial changes for distributed jmeter Signed-off-by: hiteshwani <[email protected]> * Added jmeter slaves script and Dockerfile Signed-off-by: hiteshwani <[email protected]> * Removed duplicate files and imported from existing jmeter executor Signed-off-by: hiteshwani <[email protected]> * Add secret refs for git username and token for slave pods Signed-off-by: hiteshwani <[email protected]> * Support for user provided plugins (#2) * Support for user provided plugins * Add secret refs for git username and token for slave pods Signed-off-by: hiteshwani <[email protected]> * Modified logic for adding JMETER_USER_PLUGINS_FOLDER env var Signed-off-by: hiteshwani <[email protected]> * Support for user provided plugins Signed-off-by: Aman Parauliya <[email protected]> * Add secret refs for git username and token for slave pods Signed-off-by: hiteshwani <[email protected]> * Modified logic for adding JMETER_USER_PLUGINS_FOLDER env var Signed-off-by: hiteshwani <[email protected]> --------- Signed-off-by: hiteshwani <[email protected]> Signed-off-by: Aman Parauliya <[email protected]> Co-authored-by: hiteshwani <[email protected]> * Update README file for Jmeterd Signed-off-by: Aman Parauliya <[email protected]> * Changed base image to kubeshop/jmeter and removed tests (#5) * Changed base image to kubeshop/jmeter and removed tests Signed-off-by: hiteshwani <[email protected]> * modify slaves script so it will not exited on error Signed-off-by: hiteshwani <[email protected]> --------- Signed-off-by: hiteshwani <[email protected]> * Support for user.properties file (#3) * Support for user provided plugins Signed-off-by: Aman Parauliya <[email protected]> * Add secret refs for git username and token for slave pods Signed-off-by: hiteshwani <[email protected]> * Modified logic for adding JMETER_USER_PLUGINS_FOLDER env var Signed-off-by: hiteshwani <[email protected]> * Added the support for user.properties file --------- Signed-off-by: Aman Parauliya <[email protected]> Signed-off-by: hiteshwani <[email protected]> Co-authored-by: hiteshwani <[email protected]> * Addressed review comments Signed-off-by: Aman Parauliya <[email protected]> * Fixed review comments of Dejan Signed-off-by: Aman Parauliya <[email protected]> * Refactored slaves pod configuration and added validation for pod name (#8) Signed-off-by: hiteshwani <[email protected]> * Update README file of Distributor JMeter Signed-off-by: Aman Parauliya <[email protected]> * Adding a new example in a new folder named giflow under the examples folder Signed-off-by: Aman Parauliya <[email protected]> * Remove plugins from /lib Signed-off-by: hiteshwani <[email protected]> --------- Signed-off-by: hiteshwani <[email protected]> Signed-off-by: Aman Parauliya <[email protected]> Co-authored-by: Aman Parauliya <[email protected]> Co-authored-by: Aman Parauliya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
This PR is supposed to add a feature to support user provided plugins for Jmeter test
Checklist (choose whats happened)
breaking change! (describe)
tested locally
tested on cluster
added new dependencies
updated the docs
added a test
Breaking changes
Changes
Fixes