-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(draw): new features, improvements and bug fixes #897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment :
1- Split your differents modification into commit. issueX = 1 or more commit. Your PR is too broad and it is hard to review.
2- Ensure the content is mobile friendly (
)
3- This is not a final review. A new review will be needed aftherward.
4- Ensure to let the draw layer been exported.. IGO raise an issue..
packages/geo/src/lib/import-export/import-export/import-export.component.html
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/import-export/import-export/import-export.component.ts
Outdated
Show resolved
Hide resolved
@LAMM26 Good job!! |
@LAMM26 One more thing, when modifying the circle, show the result of th drag..... not only a the end of the drag |
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
infra-geo-ouverte/igo2#655
infra-geo-ouverte/igo2#649
infra-geo-ouverte/igo2#646
What is the new behavior?
Issue 655:
Issue 649:
Issue 646:
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: