feat(geo.layer.vector) use sourcefield's alias on query #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think there is a link with #442 |
matrottier
commented
Oct 8, 2019
Comment on lines
612
to
632
| layer.options && | ||
| layer.options.sourceOptions && | ||
| layer.options.sourceOptions.sourceFields && | ||
| layer.options.sourceOptions.sourceFields.length >= 1 | ||
| ) { | ||
| allowedFieldsAndAlias = {}; | ||
| layer.options.sourceOptions.sourceFields.forEach(sourceField => { | ||
| const alias = sourceField.alias ? sourceField.alias : sourceField.name; | ||
| allowedFieldsAndAlias[sourceField.name] = alias; | ||
| }); | ||
| } else if (layer.options && | ||
| layer.options.source && | ||
| layer.options.source.options && | ||
| layer.options.source.options.sourceFields && | ||
| layer.options.source.options.sourceFields.length >= 1){ | ||
| allowedFieldsAndAlias = {}; | ||
| layer.options.source.options.sourceFields.forEach(sourceField => { | ||
| const alias = sourceField.alias ? sourceField.alias : sourceField.name; | ||
| allowedFieldsAndAlias[sourceField.name] = alias; | ||
| }); | ||
| } |
There was a problem hiding this comment.
to be replace.
i was searching where "sourceOptions" is set ? and why not to reference to "source.options" ?
vector layer to not have this properties and "sourceOptions" seems to be a duplicate of "source.options"
@mbarbeau
mbarbeau
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
sourceFields is not considered with vector layer
What is the new behavior?
can use sourceFields with vector layer
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
More tests have to be done if there is a breaking change