Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply restrictions programatically to search sources #418

Merged
merged 8 commits into from
Sep 19, 2019

Conversation

pelord
Copy link
Member

@pelord pelord commented Sep 18, 2019

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
When a search is triggered programmatically, there is no way to control which source is used.
The hashtag has been tested but not interesting because hashtag is linked to search result.

What is the new behavior?
adding an option property the filter the sources BEFORE the call.

2 properties added to TextSearchOptions interface

  searchType?: 'Feature' | 'Layer'; // refer to search.enum.ts SEARCH_TYPES = [FEATURE, LAYER];
  getEnabledOnly?: boolean;

searchType refer the the search source type
getEnabledOnly is to bypass or not the user's defined enabled sources.

Use fce7278 as an example.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord pelord changed the title WIP : Restrict the search source WIP : Applay restriction programatically to the search sources Sep 18, 2019
@pelord pelord changed the title WIP : Applay restriction programatically to the search sources WIP : Apply restriction programatically to the search sources Sep 18, 2019
@pelord pelord changed the title WIP : Apply restriction programatically to the search sources WIP : Apply restriction programatically to search sources Sep 18, 2019
@pelord pelord changed the title WIP : Apply restriction programatically to search sources WIP : Apply restrictions programatically to search sources Sep 18, 2019
@pelord pelord changed the title WIP : Apply restrictions programatically to search sources Apply restrictions programatically to search sources Sep 19, 2019
@mbarbeau mbarbeau merged commit 8787a5f into 1.0.0-alpha Sep 19, 2019
@mbarbeau mbarbeau deleted the searchServiceAlpha branch September 19, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants