Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename toolbar click event to trigger to avoid overriding the default… #206

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

cbourget
Copy link
Collaborator

… click event

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
The toolbar click event overrides the default click event.

What is the new behavior?
The click event has beend renamed to trigger.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@mbarbeau mbarbeau merged commit 5a040fa into master Oct 18, 2018
@mbarbeau mbarbeau deleted the toolbar-trigger-event branch October 18, 2018 14:57
ulysseskao added a commit to XimpleTech/igo2-lib that referenced this pull request Nov 1, 2018
fix(print): pdf height-width undefined

https://stackoverflow.com/questions/51487855/jspdf-width-height-show-undefined-when-set
fix(context): locale do not contains common keys (infra-geo-ouverte#192)
fix(layer-list): remove empty space above the list - fix issue infra-geo-ouverte#187 (infra-geo-ouverte#190)
feat(map): Prevent zooming on result if already contained in map extent (infra-geo-ouverte#193)

* feat(*) Prevent zooming on result if already contained im map extent

* refactor(*) refactor zoomif to zoomIfOutMapExtent & interface to enum

* fix(overlay) zoom if outside map extent

* refactor(demo) set to false because it is not provided in search module.
fix(datasource): always lowercase type
fix(search-layer): fix search layer type
refactor(*): remove unused files
chore(release): ignore untracked files
fix(context): stop propagation on button
fix(context): fix default context
fix(metadata): define metadata in layerOptions
fix(getCapabilities): merge getCapabilities and json options
feat(search-source): Provide interface for reseautq (infra-geo-ouverte#199)
feat(overlay): Feature zoom if not in extent based on feature geometry.  (infra-geo-ouverte#198)

* fix(overlay) prevent false extent overlap. Validate to coordinate level

* fix(overlay) The zoom behave is now based on geometry, not on extent.

* feat(search) Provide a zoom Level threshold to trigger zoom on feature

* fix(demo) nominatim as a enabled source

* fix(overlay) Enabling a  parameter to overide the default zoom behavior

* refactor(demo) Forgot to provideDataSourceSearchSource to demo.

* fix(overlay) click feature intersection validation

* refactor(demo) Enabling a parameter to overide the default zoom behavior

* feat(context) provide zoom to feature for sidenav

* fix(context) Validation if geometry available.

* fic(overlay) Validation if geometry available

* fix(overlay) wrong condition on geometry simplification

* rename zoomLevelTriggerFeatureZoom to zoomMaxOnSelect

* rename zoomLevelTriggerFeatureZoom to zoomMaxOnSelect
fix(ogc-filter): Fix for Angular 6 and adjustements for minilib (infra-geo-ouverte#186)

* refactor(map) a more customizable way to add overlay

* feat(wkt service) refactor and adding ways to return wkt objects

* fix(ogc-fillter interface and class) refactor interfaces and operators

* refactor(ogc-filter) bing map to ogcfilter.

* (feat) feature color used as a extent (0000 vs gray) and autorefresh

* fix(download-service) with right properties

* feat(ogc-filter) Autorefresh toggle feature extent and bind map

* refactor(wfs) interface for outputFormatDownload

* ui(ogc-filter) updating demo with proper params.

* fix(ogc-filter) Moving to angular 6 and selectionChange on select

* i18n(ogc-filter) translation for feature extent.

* feat(ogc-filter-form) AutoRefresh on change, feature extent overlay

* refactor(*) sourcefields

* refactor(wms-datasource)managing sourcefield for wms

* refactor(ogc-filter) isOgcFilterable/filtersAreEditable enabled/editable

* fix(wfs) not using filters when filters are disabled.

* refactor(ogc-filter) ogcFilters: {enabled: true,editable: true,...}

* fix(wfs) default value for ogcfilters

* ui(ogc-filter) cleaner example

* ui(ogc-filter) refresh button removed due to autorefresh on change.

* feat(ogc-filter) refactor and defining a cleaner way for refresh events

* refactor(*)move wfs-service usage from ogc-filter.service to datasources

* fix(wkt-service) Wrong regex. Was excluding some SNRC

* feat(datasource) providing data wfs-service to datasources

* fix(download-service) Adjustement on interface and services params.

* feat(wms wfs)  wfs for wms source and common interfaces on wms and wfs

* fix(filterable-datasource) Let filterable layer apply active filters.

* refactor(ogc-fliter) adjustements for wms with linked wfs

* fix(ogc-filter) active filter geometry footprint on init

* refactor(ogc-filter) various interfaces

* fix(ogc-filter) fixing wrong conflict resolution.

* fic(ogc-filter-button) Fix button integration

* fix(ogc-filter-button) fix button integration into layer-list

* fix(ogc-filter-button) download button shown.

* ui(ogc-filter) hide spatial extent button if no geometry active.

* fix(ogc-filter-button) fix button integration into layer-list

* Update layer.component.ts

* Update ogc-filter.component.ts

* lint code

* Update map.ts

* remove inused import

* fix position buttons layer
fix(ogc-filter-button) Placement and duplicated
fix(ogc-filter-button)  wrong map provided. Using map from directive.
fix(searc-result) Default Behavior on focus
feat(igo-toast) provite zoom to feature for mobile devices
fix(message-service) Attempt to fix Issue infra-geo-ouverte#194
feat(notifications): upgrade angular-notifications
fix(layer-list): fix css of the sorting button and filter on mobile
fix(time-filter): take current date if min is not defined
fix(time-filter): get options from capabilities
fix(css): add padding to forms
refactor(search-result)Provide interface for search-results (focusFirst)
fix(context-service) enable tools options configuration
fix(reseautq) fix false call due to regex remplacement.
feat(backdrop): let the backdrop be shown on any media instead of on mobiles only (infra-geo-ouverte#202)
feat(toolbar): toolbar emit a click event as well as the usual select event (infra-geo-ouverte#201)
fix(WMTS): GetCapbilities import error (infra-geo-ouverte#205)

* fix WMTS GetCapbilities import error

* remove unnecessary import
fix(toolbar): rename toolbar click event to trigger to avoid overriding the default click event (infra-geo-ouverte#206)
fix(import-export): fix drop file on map
fix(context): send type layer to api
fix(context): rename order to zIndex
refactor(query): Moving from displayField to sourceOptions.queryTitle (infra-geo-ouverte#208)

* fix)(datasource-interface) enable displayField for vector or wfs Source

* refactor(query) Moving from displayField to sourceOptions.queryTitle

* refactor(datasource.interface) displayField (use queryTitle instead)

* refactor(query) console & remove title

* refactor(reseau-transport-quebec) decrecated empty observable
feat(wms-datasources) a way to bypass info_format given for getinfo
feat(custom-html) building custom html from param.
feat(about-tool) Adding a new tool named About
ui(custom-html) default padding in pixels
fix(custom-html): add padding
fix(ogc-filter) WMS with linked wfs
fic(ogc-filter) fix  geometry fieldname
fix(dropGeoFile): directive not working (build prod - aot)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants