Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): Make it optional to have a workspace source #1659

Closed
wants to merge 1 commit into from

Conversation

cbourget
Copy link
Collaborator

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
If there is no workspace search source, the search state fails to instantiate itself and an error is thrown upon loading the app.

What is the new behavior?
The workspace source is optional and the search state doesn't fail if there is none.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord
Copy link
Member

pelord commented Mar 25, 2024

@cbourget Check this PR. I think your PR is a duplicate. If you confirm it, please close your PR.

#1609

@cbourget
Copy link
Collaborator Author

It is. Thank you for pointing that out.

@cbourget cbourget closed this Mar 25, 2024
@alecarn alecarn deleted the Search-State-WKS-Source branch August 14, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants