feat(geo): split the add catalog dialog in tabs, predefined catalog a… #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd custom service
alecarn
requested changes
Feb 26, 2024
packages/geo/src/lib/catalog/catalog-library/catalog-library.component.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/catalog/catalog-library/catalog-library.component.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/catalog/catalog-library/catalog-library.component.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/catalog/catalog-library/catalog-library.component.ts
Show resolved
Hide resolved
packages/geo/src/lib/catalog/catalog-library/catalog-library.component.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/catalog/catalog-library/catalog-library.component.ts
Outdated
Show resolved
Hide resolved
|
@alecarn Peux tu y jeter un coup d'oeil, c'est en prod chez nous depuis le printemps passé. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
If we configure composite catalogs to be added to the predefined list, the catalogs is not added to the catalog store.
refer to #1631
What is the new behavior?
Refactor the add catalog dialog to split predefined catalog and custom catalogs.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: