Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature zoom #154

Merged
merged 6 commits into from
May 18, 2018
Merged

Fix feature zoom #154

merged 6 commits into from
May 18, 2018

Conversation

pelord
Copy link
Member

@pelord pelord commented May 17, 2018

highlighting result in the feature list. But do not zoom on. action = 'none'

@@ -98,6 +98,11 @@ export class AppComponent implements OnInit {
const features: Feature[] = results.features;
if (features[0]) {
this.featureService.updateFeatures(features, features[0].source);
const a = features.filter(feature =>
feature.source === 'Entités cliquées' ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use translation strings

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -61,7 +61,9 @@ export class OverlayDirective implements OnInit, OnDestroy {

this.map.addOverlay(olFeature);
}, this);

if (features[0].source === 'Entités cliquées' || features[0].source === 'Clicked Feature') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use translation strings

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@pelord
Copy link
Member Author

pelord commented May 18, 2018

New cleaner behavior. If you select a feature in the feature list, if the feature extent intersects the map extent, highlight feature only. If feature extents do not intersects, then move to .

@mbarbeau mbarbeau merged commit a7f7dcb into master May 18, 2018
@mbarbeau mbarbeau deleted the fixFeatureZoom branch May 18, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants