fix(geo): fix home Extent Button Options #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aziz-access
added
the
bug
alecarn
reviewed
Oct 13, 2023
| @@ -36,11 +36,11 @@ export class HomeExtentButtonComponent { | |||
| this.configService.getConfig('homeExtentButton'); | |||
|
|
|||
| this.homeExtentButtonExtent = | |||
| this.extentOverride || homeExtentButtonOptions.homeExtButtonExtent; | |||
| this.extentOverride || homeExtentButtonOptions?.homeExtButtonExtent; | |||
There was a problem hiding this comment.
Qu'est-ce qu'il se passe lorsqu'on a pas de @input "*Override" et de config? Est-ce que le button fonctionne quand même?
There was a problem hiding this comment.
oui fonctionne, just affichage
alecarn
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior? (You can also link to an open issue here)
this behavior related to #1391
What is the new behavior?
fix bug if homeExtentButton config is empty
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: