feat(ogcFilters): add multiple selection for autocomplete with chips #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multi-select n'est pas encore implementé (l'onglet de recherche se ferme quand on sélectionne un option pour le moment)
Changement de autocompleteEnabled: BehaviorSubject() vers autocompleteEnableds: BehaviorSubject([]) La logique pour les checkboxes ne fonctionne pas - les cases cochées ne correspondent pas aux filtres appliquées pour le moment
Certains petits problèmes existent toujours: - cursor pas en pointer sur les options autocomplete - couleur grise au lieu de noir pour les options autocomplete - la liste d'options ne s'affiche pas avec un input de ""
un seul problème restant: les options ne s'affichent que lorsqu'on écrit dans la zone de recherche autocomplete (au lieu de montrer les options avant). Peut-être est-ce un comportement de la fonctionalité de filtrage autocomplete?
autocomplete uses debounceTime after user modifies autocomplete search criteria before updating the list of filter options. Chip list will be shown only when the total number of filter options does not exceed a certain value (currently set to 2)
matt-litwiller
added
the
enhancement
|
Should be good to go |
LAMM26
approved these changes
Dec 20, 2023
|
@LAMM26 Pourrais-tu nous donner des instructions sur comment tester cette PR? |
Dans l'assemblage igo2, il est possible de tester avec le contexte des filtres attributaires -> couche radars photos. Le dernier filtre est de type autocomplete et il devrait être possible de tester la sélection multiple. |
filtres-attributaires-autocomplete
|
@LAMM26 Je n'ai pas été en mesure de tester, la sélection multiple ne s'affiche pas et dans la console on retrouve des erreurs. |
|
Ça ne semble pas fonctionner: Enregistrement.2024-05-15.094505.mp4 |
…/infra-geo-ouverte/igo2-lib into filtres-attributaires-autocomplete
alecarn
requested changes
May 31, 2024
There was a problem hiding this comment.
Il y a aussi un problème de flickering dans le menu de sélection
https://github.com/infra-geo-ouverte/igo2-lib/assets/133774929/ea858ba1-51ec-4446-ac6d-dffa5358413a
packages/geo/src/lib/filter/ogc-filter-selection/ogc-filter-selection.component.ts
Outdated
Show resolved
Hide resolved
alecarn
approved these changes
Jun 3, 2024
alecarn
pushed a commit
that referenced
this pull request
Jun 5, 2024
# [17.0.0-next.12](v17.0.0-next.11...v17.0.0-next.12) (2024-06-05) ### Features * **ogcFilters:** add multiple selection for autocomplete with chips ([#1274](#1274)) ([c0235b0](c0235b0))
|
🎉 This PR is included in version 17.0.0-next.12 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
alecarn
pushed a commit
that referenced
this pull request
Aug 22, 2024
# [17.0.0](v16.3.0...v17.0.0) (2024-08-22) ### Bug Fixes * **auth:** include submodule scss ([8b40bcf](8b40bcf)) * **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105)) * build ([edec59d](edec59d)) * **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013)) * bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca)) * bump version ([e315fc1](e315fc1)) * **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb)) * **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd)) * **context:** poi-button add PoiService provider ([7388ac4](7388ac4)) * **context:** revert change causing duplicate list ([fd525c2](fd525c2)) * **core:** add more details to test (Re-Trigger pipeline) ([af7d981](af7d981)) * **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97)) * **demo:** add doc for icons ([0526198](0526198)) * **demo:** directions add required search sources ([3f251e7](3f251e7)) * deploy ([3f11802](3f11802)) * **feature-details:** fix depot url regex ([#1690](#1690)) ([57c425c](57c425c)) * **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb)) * **geo:** color-picker style adjustments for the modal ([#1681](#1681)) ([8e0561e](8e0561e)) * **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258)) * **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8)) * **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7)) * **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb)) * **geo:** ogc filter, remove invalid character for the As filter ([#1651](#1651)) ([2303525](2303525)) * **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b)) * **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1)) * **geo:** register svg icon for layer-list ([de1fa78](de1fa78)) * **icon:** revert some icon change ([04fd431](04fd431)) * **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83)) * **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6)) * **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913)) * lint commit message ([#1684](#1684)) ([02fcf07](02fcf07)) * missing auth dependencies in geo and integration ([5269984](5269984)) * ol version to 9.1.0 ([7483865](7483865)) * release-demo path ([3180d05](3180d05)) * retry publish ([237bc1b](237bc1b)) * **search-bar:** trigger search on click ([114f911](114f911)) * **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1)) * **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3)) * Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556) * Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619) ### Features * **auth:** configure auth with provider ([e046947](e046947)) * **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906)) * automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e)) * **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2)) * **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb)) * **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a)) * **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda)) * **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562)) * **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4)) * **ogcFilters:** add multiple selection for autocomplete with chips ([#1274](#1274)) ([c0235b0](c0235b0)) * replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495)) ### BREAKING CHANGES * **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root. - Analytics capability is provided with the SearchService directly. - DirectionModule, provideDirectionsSourceService is removed, use the provideDirection. * **auth:** Replace by provideAuth and call the component directly * **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration * IgoLanguageModule don't import TranslateModule.forRoot defaultLanguageLoader is not exported anymore * 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig * build(packagr): keep only one config * feat(core): split in submodule for bundle optimization BREAKING CHANGES - refact(compression): convert and move to utils packages BREAKING CHANGE * build(clean-exports): account all keys in the exports object * IgoLanguageModule don't import TranslateModule.forRoot defaultLanguageLoader is not exported anymore - provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig * feat(demo): Convert all components, directives and pipes to standalone * ToolboxColor is now a type
|
🎉 This PR is included in version 17.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
Single selection autocomplete
No checkboxes
No chips
What is the new behavior?
Multiple selection autocomplete
Added checkboxes for options
Added chips
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information:
