Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert accent hashtag #1258

Merged
merged 4 commits into from
Jun 9, 2023
Merged

Insert accent hashtag #1258

merged 4 commits into from
Jun 9, 2023

Conversation

MSPKarengeo
Copy link
Contributor

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
It is not possible to search with accented words when we search with hashtag.

What is the new behavior?
When we have words with an accent, we can perform searches. In the same way, if the keyword has a (-), such as #region-administrative, the search engine will identify the searched word

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@MSPKarengeo MSPKarengeo requested review from pelord, LAMM26 and alecarn May 25, 2023 12:13
Copy link
Collaborator

@alecarn alecarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça me semble bien beau tout ça, good job!

@alecarn alecarn changed the base branch from master to next June 9, 2023 12:58
@alecarn alecarn merged commit cf74db7 into next Jun 9, 2023
alecarn pushed a commit that referenced this pull request Jun 12, 2023
* premier_test_ajout_hastags

* insert_accent_to_the_keywords_in_order_to_use_hashtag_and(-)

---------

Co-authored-by: karengeo <[email protected]>
(cherry picked from commit cf74db7)
alecarn added a commit that referenced this pull request Jun 12, 2023
* Insert accent hashtag (#1258)

* premier_test_ajout_hastags

* insert_accent_to_the_keywords_in_order_to_use_hashtag_and(-)

---------

Co-authored-by: karengeo <[email protected]>
(cherry picked from commit cf74db7)

* Corriger le parseInt qui ajuste normalement les attributs en integer (#1257)

* Corriger le parseInt qui ajuste normalement les attributs en integer

* Make condition a function

(cherry picked from commit 1d807d6)

* fix(draw): drawing circle crash whole drawing component. (#1273)

(cherry picked from commit 3998dcc)

* chore(Package): run the build once

* 1.15.3

---------

Co-authored-by: MSPKarengeo <[email protected]>
Co-authored-by: Michael Lane <[email protected]>
Co-authored-by: Pierre-Étienne Lord <[email protected]>
@alecarn alecarn mentioned this pull request Jun 12, 2023
5 tasks
alecarn added a commit that referenced this pull request Jun 14, 2023
* Insert accent hashtag (#1258)

* premier_test_ajout_hastags

* insert_accent_to_the_keywords_in_order_to_use_hashtag_and(-)

---------

Co-authored-by: karengeo <[email protected]>
(cherry picked from commit cf74db7)

* Corriger le parseInt qui ajuste normalement les attributs en integer (#1257)

* Corriger le parseInt qui ajuste normalement les attributs en integer

* Make condition a function

(cherry picked from commit 1d807d6)

* fix(draw): drawing circle crash whole drawing component. (#1273)

(cherry picked from commit 3998dcc)

* chore(Package): run the build once

* 1.15.3

---------

Co-authored-by: MSPKarengeo <[email protected]>
Co-authored-by: Michael Lane <[email protected]>
Co-authored-by: Pierre-Étienne Lord <[email protected]>
pelord added a commit that referenced this pull request Jun 14, 2023
* Insert accent hashtag (#1258)

* premier_test_ajout_hastags

* insert_accent_to_the_keywords_in_order_to_use_hashtag_and(-)

---------

Co-authored-by: karengeo <[email protected]>
(cherry picked from commit cf74db7)

* Corriger le parseInt qui ajuste normalement les attributs en integer (#1257)

* Corriger le parseInt qui ajuste normalement les attributs en integer

* Make condition a function

(cherry picked from commit 1d807d6)

* fix(draw): drawing circle crash whole drawing component. (#1273)

(cherry picked from commit 3998dcc)

* chore(Package): run the build once

* 1.15.3

* refactor(workspaces): move common method to workspace utils

* feat(workspaces): sourcefields with types add a cellClassFunc to the table template

* refactor(entity-table): typo

* fix(workspace): table scroll/overflow was not accessible

* lint

* lint

* wip

---------

Co-authored-by: MSPKarengeo <[email protected]>
Co-authored-by: Michael Lane <[email protected]>
Co-authored-by: Alexandre Caron <[email protected]>
@alecarn alecarn deleted the insert_accent_hashtag branch August 24, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants