-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert accent hashtag #1258
Merged
Merged
Insert accent hashtag #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecarn
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ça me semble bien beau tout ça, good job!
alecarn
pushed a commit
that referenced
this pull request
Jun 12, 2023
* premier_test_ajout_hastags * insert_accent_to_the_keywords_in_order_to_use_hashtag_and(-) --------- Co-authored-by: karengeo <[email protected]> (cherry picked from commit cf74db7)
alecarn
added a commit
that referenced
this pull request
Jun 12, 2023
* Insert accent hashtag (#1258) * premier_test_ajout_hastags * insert_accent_to_the_keywords_in_order_to_use_hashtag_and(-) --------- Co-authored-by: karengeo <[email protected]> (cherry picked from commit cf74db7) * Corriger le parseInt qui ajuste normalement les attributs en integer (#1257) * Corriger le parseInt qui ajuste normalement les attributs en integer * Make condition a function (cherry picked from commit 1d807d6) * fix(draw): drawing circle crash whole drawing component. (#1273) (cherry picked from commit 3998dcc) * chore(Package): run the build once * 1.15.3 --------- Co-authored-by: MSPKarengeo <[email protected]> Co-authored-by: Michael Lane <[email protected]> Co-authored-by: Pierre-Étienne Lord <[email protected]>
alecarn
added a commit
that referenced
this pull request
Jun 14, 2023
* Insert accent hashtag (#1258) * premier_test_ajout_hastags * insert_accent_to_the_keywords_in_order_to_use_hashtag_and(-) --------- Co-authored-by: karengeo <[email protected]> (cherry picked from commit cf74db7) * Corriger le parseInt qui ajuste normalement les attributs en integer (#1257) * Corriger le parseInt qui ajuste normalement les attributs en integer * Make condition a function (cherry picked from commit 1d807d6) * fix(draw): drawing circle crash whole drawing component. (#1273) (cherry picked from commit 3998dcc) * chore(Package): run the build once * 1.15.3 --------- Co-authored-by: MSPKarengeo <[email protected]> Co-authored-by: Michael Lane <[email protected]> Co-authored-by: Pierre-Étienne Lord <[email protected]>
pelord
added a commit
that referenced
this pull request
Jun 14, 2023
* Insert accent hashtag (#1258) * premier_test_ajout_hastags * insert_accent_to_the_keywords_in_order_to_use_hashtag_and(-) --------- Co-authored-by: karengeo <[email protected]> (cherry picked from commit cf74db7) * Corriger le parseInt qui ajuste normalement les attributs en integer (#1257) * Corriger le parseInt qui ajuste normalement les attributs en integer * Make condition a function (cherry picked from commit 1d807d6) * fix(draw): drawing circle crash whole drawing component. (#1273) (cherry picked from commit 3998dcc) * chore(Package): run the build once * 1.15.3 * refactor(workspaces): move common method to workspace utils * feat(workspaces): sourcefields with types add a cellClassFunc to the table template * refactor(entity-table): typo * fix(workspace): table scroll/overflow was not accessible * lint * lint * wip --------- Co-authored-by: MSPKarengeo <[email protected]> Co-authored-by: Michael Lane <[email protected]> Co-authored-by: Alexandre Caron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
It is not possible to search with accented words when we search with hashtag.
What is the new behavior?
When we have words with an accent, we can perform searches. In the same way, if the keyword has a (-), such as #region-administrative, the search engine will identify the searched word
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: