Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geolocation): better handling view zoom/move + show movement direction #1209

Merged
merged 11 commits into from
Mar 31, 2023

Conversation

pelord
Copy link
Member

@pelord pelord commented Mar 24, 2023

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
1-When geolocation is set to followPosition, the view is updated on each pan.
2-On position change, the activity spinner turn to handle position change.
3- Direction if your location change.

What is the new behavior?
1- When geolocation is set to followPosition, if the feature position is out of view (inside 10% of view inner margin OR outside view) the view will pan to the location, if the feature position is into the view, no action are done.
2- Do not delete the geolocation feature, update geometry instead.
3- show displacement direction

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord pelord changed the title feat(geolocation): better handling view zom/move + show geolocatioin heading feat(geolocation): better handling view zom/move + show geolocation heading Mar 24, 2023
@pelord pelord changed the title feat(geolocation): better handling view zom/move + show geolocation heading feat(geolocation): better handling view zoom/move + show geolocation heading Mar 24, 2023
@pelord pelord changed the title feat(geolocation): better handling view zoom/move + show geolocation heading feat(geolocation): better handling view zoom/move + show movement direction Mar 31, 2023
@pelord pelord merged commit 7e82ee4 into next Mar 31, 2023
@pelord pelord deleted the gf branch March 31, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants