Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawing guide): Fix a regression to the drawing guide that wasn't… #1201

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

cbourget
Copy link
Collaborator

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
This is a reoping of PR 1016.
A regression in the drawing guide in the geometry-input component assumes that we are drawing circles. It doesn't work with any other style.

What is the new behavior?
It works with other styles as it should. I'm not sure the demo provides a way to test that easily but I did test it.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord
Copy link
Member

pelord commented Mar 22, 2023

@cbourget how to test/validate?

@cbourget
Copy link
Collaborator Author

You need a <igo-geometry-form-field> with [drawGuide]=true. This will render a number field input with a radius value, in pixels. When drawing a circle with that radius value is visible around the cursor. This the drawing guide.

I'm not sure if the demo has a geometry field that would allow you to test that. On my end, I tested it in the FADQ app.

@pelord pelord merged commit 7bfb646 into next Mar 22, 2023
@pelord pelord deleted the drawing-guide branch March 22, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants