Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(*): remove language service where used to translate a message #1196

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Conversation

pelord
Copy link
Member

@pelord pelord commented Mar 17, 2023

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
Message content was translated before being sent to message service. Although, message service is also doing a translation...

What is the new behavior?
Remove pre-translation for message sent to message-service. This refactor allow messages to be translated live.

Ex, a message with a undefined duration was not translated IF the browser's language is changed.
Now, if message-service get a translation key instead of a translated message, the message will be transated if the language is changed....

Plus, allow to remove a lot of language service from each component, this is a attempt to fix #1004

Related to :
#1004
#1110

@ameliebernier Major refactor need to be reviewed
@gignacnic Check this specific file (packages/geo/src/lib/map/shared/mapOffline.directive.ts) , I had to slightly change this part of the code....

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord
Copy link
Member Author

pelord commented Mar 17, 2023

chrome_2023-03-17_09-17-35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant