refactor(*): remove language service where used to translate a message #1196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
Message content was translated before being sent to message service. Although, message service is also doing a translation...
What is the new behavior?
Remove pre-translation for message sent to message-service. This refactor allow messages to be translated live.
Ex, a message with a undefined duration was not translated IF the browser's language is changed.
Now, if message-service get a translation key instead of a translated message, the message will be transated if the language is changed....
Plus, allow to remove a lot of language service from each component, this is a attempt to fix #1004
Related to :
#1004
#1110
@ameliebernier Major refactor need to be reviewed
@gignacnic Check this specific file (packages/geo/src/lib/map/shared/mapOffline.directive.ts) , I had to slightly change this part of the code....
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: