Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geo): save search results in layer #1179

Merged
merged 21 commits into from
Mar 15, 2023
Merged

feat(geo): save search results in layer #1179

merged 21 commits into from
Mar 15, 2023

Conversation

aziz-access
Copy link
Contributor

What is the current behavior? (You can also link to an open issue here)
This update relate to the issue 896 in igo2.

What is the new behavior?
Save search results to an existing or a new layer.

@aziz-access aziz-access added enhancement New features and improvements // Nouvelles fonctionnalités et améliorations in progress In progress // Développement en cours labels Feb 1, 2023
@aziz-access aziz-access self-assigned this Feb 1, 2023
Copy link
Contributor

@PhilippeLafreniere18 PhilippeLafreniere18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without testing, just a few minor comments

Copy link
Contributor

@PhilippeLafreniere18 PhilippeLafreniere18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two problems here :

  • I hit the following error when adding a new search feature to an existing search layer
    image
  • It seems to have a problem with z index criteria. Layer list should be sorted by z index, but when adding search layer, weird behavior is happening

image
image

@aziz-access aziz-access added to test Issues that need testing by PO // Demandes qui ont besoin d'être testées par un pilote and removed in progress In progress // Développement en cours labels Feb 28, 2023
@PhilippeLafreniere18 PhilippeLafreniere18 added ready to merge and removed to test Issues that need testing by PO // Demandes qui ont besoin d'être testées par un pilote labels Mar 9, 2023
@pelord pelord merged commit a0d727b into next Mar 15, 2023
@pelord pelord deleted the saveSearchResultInLayer branch March 15, 2023 14:44
cbourget pushed a commit that referenced this pull request Mar 21, 2023
* feat(geo): save search results in layer

* create layer dialog

* clean code

* code cleaning back with collapsible component with first state

* add feature ti layer btn and dialog

* start create layer and add feature

* edit layer

* create layer and add new feature

* save feature in layer

* add translation and solve lint

* solve lintt

* solve comments

* correct igo-search-layer

* solve typo

* add searchLayerStores to save new the storest and delete zIndex property from drowinglayer to solve zindex issue

* solve lint error

* typo

* refactor(search-bar): allow queryable / switch to Feature

* refactor(search-results-add-button): renamed const

* fix/feat(search-results): fix translation/add feature properties

---------

Co-authored-by: Philippe Lafreniere <[email protected]>
Co-authored-by: Pierre-Étienne Lord <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features and improvements // Nouvelles fonctionnalités et améliorations ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants