feat(geo): update queryUrl with min max resolution #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aziz-access
added
enhancement
…ouverte/igo2-lib into customQueryUrlWithMinMaxParam merge remote with local
PhilippeLafreniere18
added
ready to merge
and removed
in progress
pelord
reviewed
Feb 9, 2023
|
@matrottier veux-tu qu'on continue d'honorer l'objet initial ? On le changerait pour un array ici (queryUrls au lieu de queryUrl). À toi de voir... |
semble tiguidou ! go ! go ! go ! |
PhilippeLafreniere18
approved these changes
Mar 10, 2023
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
* feat(geo): update queryUrl with min max resolution * solve lint errors * solve lint errors.. * solve lint errors * test query * test * fix(query): fix query url bbox param * wip * branch testing new code * merge with queryUrlFix * add resolution and scale check * lint * check scale and resolution are exists * verification of resolution and scale * refactor/fix(queryUrl): fix conditions and examples for scale and resolution * fix typo * fix(query): fix htmlgml query geom * fix(query): htmlgml2 geometries were undefined or wrong --------- Co-authored-by: Philippe Lafreniere <[email protected]> Co-authored-by: Pierre-Étienne Lord <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior? (You can also link to an open issue here)
this update relate to the issue #984 Custom Query Url with min/max resolution
What is the new behavior?
add the possibility to change the url depending on the zoom/resolution of the map.