Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(geo): changer l'affichage de Query du liste collapse ver afficha… #1156

Merged
merged 5 commits into from
Mar 15, 2023

Conversation

aziz-access
Copy link
Contributor

What is the current behavior?
This update relate to the issue #862 on igo2

What is the new behavior?
Change Query display in "toast-panel" from list collapse to tab display

@aziz-access aziz-access self-assigned this Jan 4, 2023
Copy link
Contributor

@PhilippeLafreniere18 PhilippeLafreniere18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great if the toast-panel height doesn't change with each layer. Currently, if I have a lot of features of one layer and only a few from another, the panel will resize from big to small abruptly. Maybe another way would be to add an animation that can soften the resize.

@PhilippeLafreniere18
Copy link
Contributor

Event with the animation, the resize can be a bit abrupt especially when you pass from one layer that has many query features from one that has few... I really think the best here would be to fix the height of the panel according to the fullExtent attribute and the layer that has the highest number of query features.
chrome_bXrYiq8n85

@aziz-access aziz-access added the in progress In progress // Développement en cours label Feb 28, 2023
@PhilippeLafreniere18 PhilippeLafreniere18 added ready to merge 1.14.2 and removed in progress In progress // Développement en cours not ready labels Mar 8, 2023
@pelord pelord merged commit 1a79c2d into next Mar 15, 2023
@pelord pelord deleted the changeToastPanelOnTabsMode branch March 15, 2023 18:06
cbourget pushed a commit that referenced this pull request Mar 21, 2023
…st (#1156)

* perf(geo): changer l'affichage de Query du liste collapse ver affichage par onglet

* verify the result for toast-panel or search-result-tools

* rename variable

* add animation to resize tabs content

---------

Co-authored-by: Pierre-Étienne Lord <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants