Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(regexService): config define regex list/object #1125

Merged
merged 6 commits into from
Mar 3, 2023

Conversation

pelord
Copy link
Member

@pelord pelord commented Nov 4, 2022

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
new feature.

What is the new behavior?
In a config.json or environnement.ts.. you could define a config to control regexes from config... instead of coding them.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord
Copy link
Member Author

pelord commented Nov 4, 2022

Example not used at this moment in the app.

  "regex": {
    "geoservice": [
      {
        "url": "http://youdomain/wmsService....",
        "type": "wms",
        "columnForLayerName": "layer"
      }
    ]
  }

@pelord pelord added to test Issues that need testing by PO // Demandes qui ont besoin d'être testées par un pilote simple labels Nov 4, 2022
@pelord pelord marked this pull request as draft November 10, 2022 17:47
@pelord pelord marked this pull request as ready for review March 1, 2023 15:01
@PhilippeLafreniere18 PhilippeLafreniere18 merged commit 1199e18 into next Mar 3, 2023
@pelord pelord deleted the regexService2 branch March 15, 2023 15:28
cbourget pushed a commit that referenced this pull request Mar 21, 2023
Co-authored-by: Pierre-Etienne Lord <[email protected]>
Co-authored-by: Pierre-Étienne Lord <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simple to test Issues that need testing by PO // Demandes qui ont besoin d'être testées par un pilote
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants