Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Circular dependency with toastr #1005

Merged
merged 1 commit into from
Mar 17, 2022
Merged

fix: Circular dependency with toastr #1005

merged 1 commit into from
Mar 17, 2022

Conversation

cbourget
Copy link
Collaborator

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
See #1004

What is the new behavior?
Fix the issue with toastr not being able to attach itself to the app when it is loaded during app initialization.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord pelord merged commit ebe4585 into next Mar 17, 2022
@pelord pelord deleted the toastr-attach-view branch March 25, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants