Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(geo): print add option to show hide north arrow direction #1672

Merged
merged 4 commits into from
May 24, 2024
Merged

feat(geo): print add option to show hide north arrow direction #1672

merged 4 commits into from
May 24, 2024

Conversation

aziz-access
Copy link
Contributor

What is the current behavior? (You can also link to an open issue here)

this behavior related to #1596

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@aziz-access aziz-access added the enhancement New features and improvements // Nouvelles fonctionnalités et améliorations label Apr 19, 2024
@aziz-access aziz-access self-assigned this Apr 19, 2024
@aziz-access aziz-access linked an issue Apr 19, 2024 that may be closed by this pull request
Print - Add an option to always show the north arrow #1596
Open
@aziz-access aziz-access requested review from alecarn and pelord April 19, 2024 19:30
alecarn
alecarn requested changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@alecarn alecarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un petit changement sinon

packages/geo/src/locale/fr.geo.json Outdated
@@ -346,7 +346,8 @@
"bottomright": "Coin bas droit de la carte",
"newpage": "Sur une nouvelle page",
"newimage": "Sur une nouvelle image"
}
},
"showNorthArrow": "Afficher la flèche nord"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Afficher la flèche du nord

packages/geo/src/lib/print/shared/print.service.ts Outdated
)[0] as HTMLElement;
if (!HTMLButton) {
return null;
addNorthDirectionArrow(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est utilisé a quel endroit cette méthode?

packages/geo/src/lib/print/shared/print.service.ts Outdated
this.document.body.appendChild(div);
const canvas = await html2canvas(div, { backgroundColor: null }).catch(
(e) => {
console.log(e);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COnsole log?

packages/geo/src/lib/print/shared/print.service.ts Outdated
@@ -1148,6 +1180,23 @@ export class PrintService {

newContext.drawImage(mapResultCanvas, 0, positionHCanvas);

if (showNorthArrow) {
const northDirectionArrowCanvas =
await this.createNorthDirectionArrow(map);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi qu'on retrounve à deux endroits createNorthDirectionArrow?
Avant il était centralisé dans une méthode, peut-être conserver la même stratégie!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi qu'on retrounve à deux endroits createNorthDirectionArrow? Avant il était centralisé dans une méthode, peut-être conserver la même stratégie!

on a deux types d'export 'PDF' et 'IMAGE', c'est pourquoi vous le trouvez deux fois.
je vais essayer d'utiliser la même stratégie qu'avant...

@aziz-access @alecarn
fix(geo): Print set the same horizontal margin for the map
e63c672 
code review

code improvment

change variable name

fix(geo): print - map position, comment and projection position and georeference

code review

change variable names

add comments and change variable name

merge and update solve comments

solve package lock issue
@alecarn alecarn force-pushed the print-center-the-map branch from 6ba9b3e to e63c672 Compare April 24, 2024 19:11
@aziz-access aziz-access force-pushed the 1596-print-add-option-to-show-north-arrow branch 2 times, most recently from 654f5ce to 681a255 Compare April 25, 2024 13:56
Base automatically changed from print-center-the-map to next May 15, 2024 19:12
@aziz-access
fix(geo): Print set the same horizontal margin for the map
1f460e5 
code review

code improvment

change variable name

fix(geo): print - map position, comment and projection position and georeference

code review

change variable names

add comments and change variable name

merge and update solve comments

package-lock

feat(geo): print add option to show hide north arrow dorection

feat(geo): print show north arrow if format is image

solve pakage-loc file

solve comments

code improvement

Revert "fix(geo): Print set the same horizontal margin for the map"

This reverts commit e63c672.
@aziz-access aziz-access force-pushed the 1596-print-add-option-to-show-north-arrow branch from 594782a to 1f460e5 Compare May 15, 2024 19:43
@aziz-access aziz-access requested a review from alecarn May 24, 2024 13:34
@alecarn alecarn merged commit 8b0e11b into next May 24, 2024
4 checks passed
@alecarn alecarn deleted the 1596-print-add-option-to-show-north-arrow branch May 24, 2024 14:29
alecarn pushed a commit that referenced this pull request May 30, 2024
@semantic-release-bot
chore(release): 17.0.0-next.1 [skip ci]
811e3d4 
# [17.0.0-next.1](v16.3.0...v17.0.0-next.1) (2024-05-30)

### Bug Fixes

* **auth:** include submodule scss ([8b40bcf](8b40bcf))
* **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105))
* **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013))
* bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca))
* **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb))
* **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd))
* **context:** poi-button add PoiService provider ([7388ac4](7388ac4))
* **context:** revert change causing duplicate list ([fd525c2](fd525c2))
* **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97))
* **demo:** add doc for icons ([0526198](0526198))
* **demo:** directions add required search sources ([3f251e7](3f251e7))
* **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb))
* **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258))
* **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8))
* **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7))
* **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb))
* **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b))
* **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1))
* **geo:** register svg icon for layer-list ([de1fa78](de1fa78))
* **icon:** revert some icon change ([04fd431](04fd431))
* **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83))
* **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6))
* **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913))
* missing auth dependencies in geo and integration ([5269984](5269984))
* ol version to 9.1.0 ([7483865](7483865))
* **search-bar:** trigger search on click ([114f911](114f911))
* **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1))
* **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3))

* Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556)
* Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619)

### Features

* **auth:** configure auth with provider ([e046947](e046947))
* **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906))
* automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e))
* **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2))
* **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb))
* **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a))
* **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda))
* **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562))
* **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4))
* replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495))

### BREAKING CHANGES

* **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root.
- Analytics capability is provided with the SearchService directly.
- DirectionModule, provideDirectionsSourceService is removed, use the provideDirection.
* **auth:** Replace by provideAuth and call the component directly
* **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
* 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig

* build(packagr): keep only one config

* feat(core): split in submodule for bundle optimization BREAKING CHANGES
- refact(compression): convert and move to utils packages BREAKING CHANGE

* build(clean-exports): account all keys in the exports object
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
- provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig

* feat(demo): Convert all components, directives and pipes to standalone
* ToolboxColor is now a type
alecarn pushed a commit that referenced this pull request May 30, 2024
@semantic-release-bot
chore(release): 17.0.0-next.1 [skip ci]
28b8f1f 
# [17.0.0-next.1](v16.3.0...v17.0.0-next.1) (2024-05-30)

### Bug Fixes

* **auth:** include submodule scss ([8b40bcf](8b40bcf))
* **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105))
* build ([0aa3f8e](0aa3f8e))
* **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013))
* bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca))
* bump version ([22ded11](22ded11))
* bump version ([b7f70d2](b7f70d2))
* bump version ([20e4e41](20e4e41))
* **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb))
* **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd))
* **context:** poi-button add PoiService provider ([7388ac4](7388ac4))
* **context:** revert change causing duplicate list ([fd525c2](fd525c2))
* **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97))
* **demo:** add doc for icons ([0526198](0526198))
* **demo:** directions add required search sources ([3f251e7](3f251e7))
* **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb))
* **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258))
* **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8))
* **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7))
* **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb))
* **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b))
* **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1))
* **geo:** register svg icon for layer-list ([de1fa78](de1fa78))
* **icon:** revert some icon change ([04fd431](04fd431))
* **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83))
* **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6))
* **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913))
* missing auth dependencies in geo and integration ([5269984](5269984))
* ol version to 9.1.0 ([7483865](7483865))
* release ([c401c56](c401c56))
* **search-bar:** trigger search on click ([114f911](114f911))
* **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1))
* **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3))

* Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556)
* Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619)

### Features

* **auth:** configure auth with provider ([e046947](e046947))
* **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906))
* automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e))
* **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2))
* **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb))
* **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a))
* **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda))
* **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562))
* **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4))
* replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495))

### BREAKING CHANGES

* **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root.
- Analytics capability is provided with the SearchService directly.
- DirectionModule, provideDirectionsSourceService is removed, use the provideDirection.
* **auth:** Replace by provideAuth and call the component directly
* **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
* 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig

* build(packagr): keep only one config

* feat(core): split in submodule for bundle optimization BREAKING CHANGES
- refact(compression): convert and move to utils packages BREAKING CHANGE

* build(clean-exports): account all keys in the exports object
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
- provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig

* feat(demo): Convert all components, directives and pipes to standalone
* ToolboxColor is now a type
alecarn pushed a commit that referenced this pull request May 30, 2024
@semantic-release-bot
chore(release): 17.0.0-next.1 [skip ci]
1112215 
# [17.0.0-next.1](v16.3.0...v17.0.0-next.1) (2024-05-30)

### Bug Fixes

* **auth:** include submodule scss ([8b40bcf](8b40bcf))
* **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105))
* build ([edec59d](edec59d))
* **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013))
* bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca))
* bump version ([e315fc1](e315fc1))
* **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb))
* **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd))
* **context:** poi-button add PoiService provider ([7388ac4](7388ac4))
* **context:** revert change causing duplicate list ([fd525c2](fd525c2))
* **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97))
* **demo:** add doc for icons ([0526198](0526198))
* **demo:** directions add required search sources ([3f251e7](3f251e7))
* **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb))
* **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258))
* **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8))
* **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7))
* **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb))
* **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b))
* **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1))
* **geo:** register svg icon for layer-list ([de1fa78](de1fa78))
* **icon:** revert some icon change ([04fd431](04fd431))
* **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83))
* **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6))
* **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913))
* missing auth dependencies in geo and integration ([5269984](5269984))
* ol version to 9.1.0 ([7483865](7483865))
* **search-bar:** trigger search on click ([114f911](114f911))
* **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1))
* **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3))

* Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556)
* Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619)

### Features

* **auth:** configure auth with provider ([e046947](e046947))
* **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906))
* automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e))
* **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2))
* **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb))
* **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a))
* **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda))
* **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562))
* **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4))
* replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495))

### BREAKING CHANGES

* **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root.
- Analytics capability is provided with the SearchService directly.
- DirectionModule, provideDirectionsSourceService is removed, use the provideDirection.
* **auth:** Replace by provideAuth and call the component directly
* **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
* 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig

* build(packagr): keep only one config

* feat(core): split in submodule for bundle optimization BREAKING CHANGES
- refact(compression): convert and move to utils packages BREAKING CHANGE

* build(clean-exports): account all keys in the exports object
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
- provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig

* feat(demo): Convert all components, directives and pipes to standalone
* ToolboxColor is now a type
alecarn pushed a commit that referenced this pull request May 30, 2024
@semantic-release-bot
chore(release): 17.0.0-next.1 [skip ci]
2dae3dd 
# [17.0.0-next.1](v16.3.0...v17.0.0-next.1) (2024-05-30)

### Bug Fixes

* **auth:** include submodule scss ([8b40bcf](8b40bcf))
* **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105))
* build ([edec59d](edec59d))
* **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013))
* bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca))
* bump version ([e315fc1](e315fc1))
* **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb))
* **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd))
* **context:** poi-button add PoiService provider ([7388ac4](7388ac4))
* **context:** revert change causing duplicate list ([fd525c2](fd525c2))
* **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97))
* **demo:** add doc for icons ([0526198](0526198))
* **demo:** directions add required search sources ([3f251e7](3f251e7))
* **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb))
* **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258))
* **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8))
* **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7))
* **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb))
* **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b))
* **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1))
* **geo:** register svg icon for layer-list ([de1fa78](de1fa78))
* **icon:** revert some icon change ([04fd431](04fd431))
* **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83))
* **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6))
* **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913))
* missing auth dependencies in geo and integration ([5269984](5269984))
* ol version to 9.1.0 ([7483865](7483865))
* retry publish ([237bc1b](237bc1b))
* **search-bar:** trigger search on click ([114f911](114f911))
* **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1))
* **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3))

* Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556)
* Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619)

### Features

* **auth:** configure auth with provider ([e046947](e046947))
* **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906))
* automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e))
* **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2))
* **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb))
* **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a))
* **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda))
* **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562))
* **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4))
* replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495))

### BREAKING CHANGES

* **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root.
- Analytics capability is provided with the SearchService directly.
- DirectionModule, provideDirectionsSourceService is removed, use the provideDirection.
* **auth:** Replace by provideAuth and call the component directly
* **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
* 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig

* build(packagr): keep only one config

* feat(core): split in submodule for bundle optimization BREAKING CHANGES
- refact(compression): convert and move to utils packages BREAKING CHANGE

* build(clean-exports): account all keys in the exports object
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
- provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig

* feat(demo): Convert all components, directives and pipes to standalone
* ToolboxColor is now a type
alecarn pushed a commit that referenced this pull request May 30, 2024
@semantic-release-bot
chore(release): 17.0.0-next.8 [skip ci]
93caee6 
# [17.0.0-next.8](v17.0.0-next.7...v17.0.0-next.8) (2024-05-30)

### Bug Fixes

* build ([edec59d](edec59d))
* bump version ([e315fc1](e315fc1))
* **demo:** add doc for icons ([0526198](0526198))
* **demo:** directions add required search sources ([3f251e7](3f251e7))
* deploy ([3f11802](3f11802))
* **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b))
* ol version to 9.1.0 ([7483865](7483865))
* retry publish ([237bc1b](237bc1b))

### Features

* automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e))
* **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda))
alecarn pushed a commit that referenced this pull request Aug 22, 2024
@semantic-release-bot
chore(release): 17.0.0 [skip ci]
91fe721 
# [17.0.0](v16.3.0...v17.0.0) (2024-08-22)

### Bug Fixes

* **auth:** include submodule scss ([8b40bcf](8b40bcf))
* **auth:** use IgoAuthModule instead of TranslateModule ([3277105](3277105))
* build ([edec59d](edec59d))
* **build:** clean up exports in the distributed package.json [#1616](#1616) ([#1617](#1617)) ([ecd7013](ecd7013))
* bump node engine version to a min of 18.13 ([e95a1ca](e95a1ca))
* bump version ([e315fc1](e315fc1))
* **common:** export EntityOperation like it used to ([#1658](#1658)) ([32bbddb](32bbddb))
* **context:** add workspace option with layers when we export context ([#1660](#1660)) ([a904cbd](a904cbd))
* **context:** poi-button add PoiService provider ([7388ac4](7388ac4))
* **context:** revert change causing duplicate list ([fd525c2](fd525c2))
* **core:** add more details to test (Re-Trigger pipeline) ([af7d981](af7d981))
* **core:** remove duplicated load of config BREAKING CHANGE ([ae2dd97](ae2dd97))
* **demo:** add doc for icons ([0526198](0526198))
* **demo:** directions add required search sources ([3f251e7](3f251e7))
* deploy ([3f11802](3f11802))
* **feature-details:** fix depot url regex ([#1690](#1690)) ([57c425c](57c425c))
* **geo:** check Capability contains layers list before loop ([#1570](#1570)) ([f4959eb](f4959eb))
* **geo:** color-picker style adjustments for the modal ([#1681](#1681)) ([8e0561e](8e0561e))
* **geo:** ensure ogc filter accept today and now ([#1622](#1622)) ([551e258](551e258))
* **geo:** garantine no comma in the beginning and end of search term ([#1608](#1608)) ([d5e20f8](d5e20f8))
* **geo:** import and export shp file ([#1665](#1665)) ([67725f7](67725f7))
* **geo:** inporting vector (igo2 issues [#1146](#1146)) ([fb9d1eb](fb9d1eb))
* **geo:** ogc filter, remove invalid character for the As filter ([#1651](#1651)) ([2303525](2303525))
* **geo:** print add option to show hide north arrow direction ([#1672](#1672)) ([8b0e11b](8b0e11b))
* **geo:** Print set the same horizontal margin for the map ([#1662](#1662)) ([ca633c1](ca633c1))
* **geo:** register svg icon for layer-list ([de1fa78](de1fa78))
* **icon:** revert some icon change ([04fd431](04fd431))
* **integration:** check if workspace search source is defined ([#1609](#1609)) ([0fd5c83](0fd5c83))
* **integration:** fix advanced coordinate error Maximum call stack size exceeded ([#1620](#1620)) ([f0c5db6](f0c5db6))
* **integration:** update coordinate if projection system change ([#1661](#1661)) ([382f913](382f913))
* lint commit message ([#1684](#1684)) ([02fcf07](02fcf07))
* missing auth dependencies in geo and integration ([5269984](5269984))
* ol version to 9.1.0 ([7483865](7483865))
* release-demo path ([3180d05](3180d05))
* retry publish ([237bc1b](237bc1b))
* **search-bar:** trigger search on click ([114f911](114f911))
* **utils:** remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one ([c08cdd1](c08cdd1))
* **utils:** Vitejs raise an error without the default import ([9354bd3](9354bd3))

* Core Refactor - migrate to secondary entrypoints to optimize the bundle size (#1625) ([4aeca83](4aeca83)), closes [#1625](#1625) [#1556](#1556)
* Release/17.0.0 (#1640) ([0cd2dcf](0cd2dcf)), closes [#1640](#1640) [#1551](#1551) [#1543](#1543) [#1563](#1563) [#1556](#1556) [#1610](#1610) [#1619](#1619)

### Features

* **auth:** configure auth with provider ([e046947](e046947))
* **auth:** remove auth.module for circular dependency ([2bc4906](2bc4906))
* automate the release and publishing with semantic-release ([#1683](#1683)) ([bc4e61e](bc4e61e))
* **directions:** added possibility to toggle between two routing sources ([#1644](#1644)) ([ef607e2](ef607e2))
* **geo:** add modularity for search and direction ([#1669](#1669)) ([cd199eb](cd199eb))
* **geo:** change printed text to Sans Serif font ([#1626](#1626)) ([748099a](748099a))
* **geo:** print - add map attribution under the map ([#1670](#1670)) ([dcb3dda](dcb3dda))
* **geo:** update Openlayers to v9 ([#1642](#1642)) ([06ed562](06ed562))
* **integration:** catalog keep selection when changing tools ([#1654](#1654)) ([946d9f4](946d9f4))
* **ogcFilters:** add multiple selection for autocomplete with chips ([#1274](#1274)) ([c0235b0](c0235b0))
* replace our icon library @mdi/angular-material with the Google Font - Material Symbol ([#1664](#1664)) ([f74c495](f74c495))

### BREAKING CHANGES

* **geo:** - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root.
- Analytics capability is provided with the SearchService directly.
- DirectionModule, provideDirectionsSourceService is removed, use the provideDirection.
* **auth:** Replace by provideAuth and call the component directly
* **auth:** AuthModule is deprecated and use the provideAuthentification for the configuration
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
* 'provideDefaultLanguageLoader' and 'provideLanguageLoader' are replaced by 'DEFAULT_LANGUAGE_LOADER' and set directly inside the TranslationConfig

* build(packagr): keep only one config

* feat(core): split in submodule for bundle optimization BREAKING CHANGES
- refact(compression): convert and move to utils packages BREAKING CHANGE

* build(clean-exports): account all keys in the exports object
* IgoLanguageModule don't import TranslateModule.forRoot
defaultLanguageLoader is not exported anymore
- provideDefaultLanguageLoader and provideLanguageLoader are replaced by DEFAULT_LANGUAGE_LOADER and set directly inside the TranslationConfig

* feat(demo): Convert all components, directives and pipes to standalone
* ToolboxColor is now a type
@alecarn
Copy link
Collaborator

alecarn commented Aug 22, 2024

🎉 This PR is included in version 17.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelord pelord Awaiting requested review from pelord

@alecarn alecarn Awaiting requested review from alecarn

Assignees

@aziz-access aziz-access

Labels
enhancement New features and improvements // Nouvelles fonctionnalités et améliorations ready to merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print - Add an option to always show the north arrow
2 participants
@aziz-access @alecarn