Skip to content

Commit

Permalink
refactor: eslint flat config (#1693)
Browse files Browse the repository at this point in the history
* refactor: update to @angular v18 BREAKING CHANGES

* refactor: eslint update to flat config

* fix: lint error for unused variable
- BREAKING CHANGES: some argument of MANY methods has been removed for unused reason
- BREAKING CHANGES: Overlay directive and service are remove since it's not functional
  • Loading branch information
alecarn authored Sep 3, 2024
1 parent d4b070a commit e6c0701
Show file tree
Hide file tree
Showing 417 changed files with 5,026 additions and 6,171 deletions.
57 changes: 0 additions & 57 deletions .eslintrc.json

This file was deleted.

106 changes: 51 additions & 55 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,32 +4,30 @@
- [Soumettre un Pull Request](soumettre-un-pull-request)
- [Guide pour les commits Git](#guide-pour-les-commits-git)

***
---

## Table of content (English)

- [Submitting bug reports](#submitting-bug-reports)
- [Submitting Pull Requests](#submitting-pull-requests)
- [Git Commit Guidelines](#git-commit-guidelines)

***
---

## Soumettre un bogue

* Détailler les navigateurs et les sytèmes d'exploitation affectés
* Indiquer la version de node utilisée
* Décrire la méthode pour reproduire le bogue

- Détailler les navigateurs et les sytèmes d'exploitation affectés
- Indiquer la version de node utilisée
- Décrire la méthode pour reproduire le bogue

## Soumettre un Pull Request

* Faire un rebase de votre branche
* Exécuter ```npm install``` pour être sûr que les dépendances soient à jour
* S'assurer que les tests sont toujours valides en exécutant:
* ```npm test```
* Ajouter des tests pour les nouvelles fonctionnalités
* Si possible, indiquer les issues concernés par le pull request

- Faire un rebase de votre branche
- Exécuter `npm install` pour être sûr que les dépendances soient à jour
- S'assurer que les tests sont toujours valides en exécutant:
- `npm test`
- Ajouter des tests pour les nouvelles fonctionnalités
- Si possible, indiquer les issues concernés par le pull request

## Guide pour les commits Git

Expand All @@ -43,49 +41,47 @@

Doit être l'un des suivants:

* feat: Nouvelle fonctionnalité (feature)
* fix: Corrige un bogue
* docs: Concernant seulement la documentation
* ui: Modification simple d'éléments de l'interface
* i18n: Ajout ou modification d'une traduction
* style: Changement n'affectant pas le sens du code (espace, formatage, point-virgule manquant, etc)
* refactor: Code qui ne corrige pas un bogue et qui n'ajoute pas de nouvelle fonctionnalité
* perf: Amélioration de la performance
* test: Ajout ou correction des tests
* chore: Changement aux opérations courantes (procédure de build, génération de la documentation, etc)
* BREAKING CHANGE: Changement non rétrocompatible
- feat: Nouvelle fonctionnalité (feature)
- fix: Corrige un bogue
- docs: Concernant seulement la documentation
- ui: Modification simple d'éléments de l'interface
- i18n: Ajout ou modification d'une traduction
- style: Changement n'affectant pas le sens du code (espace, formatage, point-virgule manquant, etc)
- refactor: Code qui ne corrige pas un bogue et qui n'ajoute pas de nouvelle fonctionnalité
- perf: Amélioration de la performance
- test: Ajout ou correction des tests
- chore: Changement aux opérations courantes (procédure de build, génération de la documentation, etc)
- BREAKING CHANGE: Changement non rétrocompatible

### Scope

Indiquer la fonctionnalité concernée par le changement.
Utiliser * si le changement affecte plus qu'une seule fonctionnalité.
Utiliser \* si le changement affecte plus qu'une seule fonctionnalité.

### Sujet

Une courte description des changement
* Commencer avec un verbe à l'impératif présent
* Ne débutant pas avec une majuscule
* Sans point à la fin

- Commencer avec un verbe à l'impératif présent
- Ne débutant pas avec une majuscule
- Sans point à la fin

***
---

## Submitting bug reports

* Please detail the affected browser(s) and operating system(s)
* Please be sure to state which version of node you're using
* Describe the method to reproduce the bug

- Please detail the affected browser(s) and operating system(s)
- Please be sure to state which version of node you're using
- Describe the method to reproduce the bug

## Submitting Pull Requests

* Please rebase your branch against the current master
* Run ```npm install``` to make sure your development dependencies are up-to-date
* Please ensure that the test suite passes and that code is lint free before submitting by running:
* ```npm test```
* If you've added new functionality, please include tests which validate its behaviour
* Make reference to possible issues on pull request comment

- Please rebase your branch against the current master
- Run `npm install` to make sure your development dependencies are up-to-date
- Please ensure that the test suite passes and that code is lint free before submitting by running:
- `npm test`
- If you've added new functionality, please include tests which validate its behaviour
- Make reference to possible issues on pull request comment

## Git Commit Guidelines

Expand All @@ -99,27 +95,27 @@ Une courte description des changement

Must be one of the following:

* feat: A new feature
* fix: A bug fix
* docs: Documentation only changes
* ui: Simple changes to the UI
* i18n: Translation
* style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
* refactor: A code change that neither fixes a bug nor adds a feature
* perf: A code change that improves performance
* test: Adding missing or correcting existing tests
* chore: Changes to the build process or auxiliary tools and libraries such as documentation generation
* BREAKING CHANGE: Changes that potentially causes other components to fail
- feat: A new feature
- fix: A bug fix
- docs: Documentation only changes
- ui: Simple changes to the UI
- i18n: Translation
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
- refactor: A code change that neither fixes a bug nor adds a feature
- perf: A code change that improves performance
- test: Adding missing or correcting existing tests
- chore: Changes to the build process or auxiliary tools and libraries such as documentation generation
- BREAKING CHANGE: Changes that potentially causes other components to fail

### Scope

The scope could be anything specifying place of the commit change.
You can use * when the change affects more than a single scope.
You can use \* when the change affects more than a single scope.

### Subject

The subject contains succinct description of the change:

* Use the imperative, present tense
* Don't capitalize first letter
* No dot (.) at the end
- Use the imperative, present tense
- Don't capitalize first letter
- No dot (.) at the end
5 changes: 3 additions & 2 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
**Please tell us about your environment:**

<!-- Operating system, Browser -->

* **Igo Version:**
- **Igo Version:**

* **Node:**
- **Node:**
<!-- node --version -->
8 changes: 2 additions & 6 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,22 +1,18 @@
**Please check if the PR fulfills these requirements**

- [ ] The commit message follows our guidelines:https://github.com/infra-geo-ouverte/igo2/blob/master/.github/CONTRIBUTING.md#git-commit-guidelines
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)


**What is the current behavior?** (You can also link to an open issue here)



**What is the new behavior?**



**Does this PR introduce a breaking change?** (check one with "x")

- [ ] Yes
- [ ] No

**If this PR contains a breaking change, please describe the impact and migration path for existing applications:**


**Other information**:
10 changes: 5 additions & 5 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@

version: 2
updates:
- package-ecosystem: "npm" # See documentation for possible values
directory: "/" # Location of package manifests
- package-ecosystem: 'npm' # See documentation for possible values
directory: '/' # Location of package manifests
schedule:
interval: "weekly"
target-branch: "next"
interval: 'weekly'
target-branch: 'next'
# Labels on pull requests for security and version updates
labels:
- "npm dependencies"
- 'npm dependencies'
58 changes: 29 additions & 29 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
# the `language` matrix defined below to confirm you have the correct set of
# supported CodeQL languages.
#
name: "CodeQL"
name: 'CodeQL'

on:
push:
branches: [ master, next ]
branches: [master, next]
pull_request:
# The branches below must be a subset of the branches above
branches: [ master, next ]
branches: [master, next]
schedule:
- cron: '44 19 * * 5'

Expand All @@ -28,40 +28,40 @@ jobs:
strategy:
fail-fast: false
matrix:
language: [ 'javascript' ]
language: ['javascript']
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
# Learn more:
# https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed

steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Checkout repository
uses: actions/checkout@v3

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
# By default, queries listed here will override any specified in a config file.
# Prefix the list here with "+" to use these queries and those in the config file.
# queries: ./path/to/local/query, your-org/your-repo/queries@main
# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
# By default, queries listed here will override any specified in a config file.
# Prefix the list here with "+" to use these queries and those in the config file.
# queries: ./path/to/local/query, your-org/your-repo/queries@main

# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v3
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v3

# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl
# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl

# ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
# and modify them (or add more) to build your code if your project
# uses a compiled language
# ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
# and modify them (or add more) to build your code if your project
# uses a compiled language

#- run: |
# make bootstrap
# make release
#- run: |
# make bootstrap
# make release

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
Loading

0 comments on commit e6c0701

Please sign in to comment.