refactor(geo): review comments and fixing typing issues

infra-geo-ouverte · Nov 28, 2024 · ab26c79 · ab26c79
1 parent 5dd8d73
commit ab26c79
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/.../geo/src/lib/workspace/widgets/interactive-selection/interactive-selection.component.html b/.../geo/src/lib/workspace/widgets/interactive-selection/interactive-selection.component.html
@@ -16,12 +16,7 @@
   </div>
 
   <div formButtons class="actions-container">
-    <button
-      mat-stroked-button
-      type="button"
-      color="primary"
-      (click)="clearForm()"
-    >
+    <button mat-stroked-button type="button" color="primary" (click)="clear()">
       {{
         'igo.geo.workspace.widget.interactiveSelection.reset.button' | translate
       }}

diff --git a/...es/geo/src/lib/workspace/widgets/interactive-selection/interactive-selection.component.ts b/...es/geo/src/lib/workspace/widgets/interactive-selection/interactive-selection.component.ts
@@ -207,7 +207,7 @@ export class InteractiveSelectionFormComponent
     )
       .pipe(pairwise())
       .subscribe(([previous, current]) => {
-        let currentValues = current;
+        const currentValues = current;
         if (previous?.action !== current.action) {
           currentValues.buffer = undefined;
         }
@@ -291,8 +291,8 @@ export class InteractiveSelectionFormComponent
       })
       .filter((f) => f);
 
-    let selectedStateToApply: boolean = false;
-    let exclusive: boolean = false;
+    let selectedStateToApply = false;
+    let exclusive = false;
     if (intersectingFeatures.length) {
       if ([SelectionAction.New, SelectionAction.Add].includes(data.action)) {
         selectedStateToApply = true;
@@ -312,7 +312,9 @@ export class InteractiveSelectionFormComponent
     );
   }
 
-  clearForm() {
+  clear() {
+    const featureStore = this.workspace.entityStore as FeatureStore;
+    featureStore.state.updateAll({ selected: false });
     this.form$.value.control.reset();
     this.setAction(SelectionAction.Add);
     this.data$.next(