Skip to content

Commit

Permalink
fix(*): remove autoscroll list and minors fix
Browse files Browse the repository at this point in the history
  • Loading branch information
mbarbeau committed Aug 8, 2019
1 parent eb52b1c commit 8455d51
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 13 deletions.
11 changes: 4 additions & 7 deletions packages/common/src/lib/list/list.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ export class ListComponent implements AfterViewInit, OnInit, OnDestroy {
}
set focusedItem(value: ListItemDirective) {
this._focusedItem = value;
if (value !== undefined) {
this.scrollToItem(value);
}
}
private _focusedItem: ListItemDirective;

Expand Down Expand Up @@ -190,6 +187,10 @@ export class ListComponent implements AfterViewInit, OnInit, OnDestroy {
this.navigationEnabled = false;
}

scrollToItem(item: ListItemDirective) {
this.el.nativeElement.scrollTop = item.getOffsetTop();
}

private init() {
this.subscribe();

Expand Down Expand Up @@ -280,8 +281,4 @@ export class ListComponent implements AfterViewInit, OnInit, OnDestroy {
break;
}
}

private scrollToItem(item: ListItemDirective) {
this.el.nativeElement.scrollTop = item.getOffsetTop();
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
form {
margin: 0 10px;
margin: 10px;
}

.full-width {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
:host {
margin: 0 10px;
margin: 10px;
}

.full-width {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { ToolComponent } from '@igo2/common';
@ToolComponent({
name: 'contextEditor',
title: 'igo.integration.tools.contexts',
icon: 'settings'
icon: 'star'
})
@Component({
selector: 'igo-context-editor-tool',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,13 @@ import { ToolState } from '../../tool/tool.state';
@ToolComponent({
name: 'contextManager',
title: 'igo.integration.tools.contexts',
icon: 'tune'
icon: 'star'
})
@Component({
selector: 'igo-context-manager-tool',
templateUrl: './context-manager-tool.component.html'
})
export class ContextManagerToolComponent {

constructor(private toolState: ToolState) {}

editContext() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { ToolComponent } from '@igo2/common';
@ToolComponent({
name: 'contextPermissionManager',
title: 'igo.integration.tools.contexts',
icon: 'settings'
icon: 'star'
})
@Component({
selector: 'igo-context-permission-manager-tool',
Expand Down

0 comments on commit 8455d51

Please sign in to comment.