fix(regex): missing regexes for geoservice

infra-geo-ouverte · Jun 5, 2023 · 4bda3ce · 4bda3ce
1 parent b79c7a0
commit 4bda3ce
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/packages/geo/src/lib/feature/shared/strategies/geo-properties.ts b/packages/geo/src/lib/feature/shared/strategies/geo-properties.ts
@@ -140,12 +140,13 @@ export class GeoPropertiesStrategy extends EntityStoreStrategy {
       const [key, values] = entry;
       values.map(value => {
         const geoService = this.propertyTypeDetectorService.getGeoService(value, allKeys);
-        const propertiesForLayerName = allKeys.filter(p => geoService.propertiesForLayerName.includes(p));
-        // providing the the first matching regex;
-        const propertyForLayerName = propertiesForLayerName.length ? propertiesForLayerName[0] : undefined;
-        if (propertyForLayerName) {
-          geoServiceAssociations.push({ url: value, urlProperty: key, layerNameProperty: propertyForLayerName, geoService });
-
+        if (geoService) {
+          const propertiesForLayerName = allKeys.filter(p => geoService.propertiesForLayerName.includes(p));
+          // providing the the first matching regex;
+          const propertyForLayerName = propertiesForLayerName.length ? propertiesForLayerName[0] : undefined;
+          if (propertyForLayerName) {
+            geoServiceAssociations.push({ url: value, urlProperty: key, layerNameProperty: propertyForLayerName, geoService });
+          }
         }
       });
     });

diff --git a/packages/geo/src/lib/utils/propertyTypeDetector/propertyTypeDetector.service.ts b/packages/geo/src/lib/utils/propertyTypeDetector/propertyTypeDetector.service.ts
@@ -7,7 +7,7 @@ import { GeoServiceDefinition } from './propertyTypeDetector.interface';
 })
 export class PropertyTypeDetectorService {
 
-  public geoServiceRegexes: GeoServiceDefinition[];
+  public geoServiceRegexes: GeoServiceDefinition[] = [];
 
   constructor(
     private regexService: RegexService