Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OH2-386 | Laboratory - edit page: fix "results" select #685

Merged
merged 5 commits into from
Nov 13, 2024
Merged

OH2-386 | Laboratory - edit page: fix "results" select #685

merged 5 commits into from
Nov 13, 2024

Conversation

SilverD3
Copy link
Contributor

See OH2-386

@mwithi mwithi requested a review from SteveGT96 October 30, 2024 22:25
@SilverD3 SilverD3 requested a review from SteveGT96 November 4, 2024 14:55
@SilverD3 SilverD3 marked this pull request as draft November 5, 2024 09:04
@SilverD3 SilverD3 marked this pull request as ready for review November 6, 2024 13:36
@mwithi
Copy link
Member

mwithi commented Nov 12, 2024 •
edited
Loading

I think the headers "Result row" and "Value" can be omitted (fixed).

but also navigating the exams seems not working properly:

chrome-capture-2024-11-12

@SilverD3
Copy link
Contributor Author

SilverD3 commented Nov 12, 2024 •
edited
Loading

but also navigating the exams seems not working properly:

Not on the scope of this issue. New issue open OH2-432

@SilverD3
Copy link
Contributor Author

I think the headers "Result row" and "Value" can be omitted:

DONE. Ready to be merged

@mwithi
Copy link
Member

mwithi commented Nov 12, 2024 •
edited by jira bot
Loading

Not on the scope of this issue. New issue open OH2-432

I do not agree really... the issue was still related to how the select is updated... anyway ok, left a comment.

mwithi
mwithi approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi merged commit 7a5c443 into informatici:develop Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwithi mwithi mwithi approved these changes

@SteveGT96 SteveGT96 Awaiting requested review from SteveGT96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SilverD3 @mwithi @SteveGT96