Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OH2-288 | Implement hospital infos edit #675

Merged

Conversation

SteveGT96
Copy link
Contributor

@SteveGT96 SteveGT96 commented Oct 9, 2024

See OH2-288

@mwithi mwithi requested a review from SilverD3 October 9, 2024 14:41
Copy link
Contributor

@SilverD3 SilverD3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General considerations

  • Refreshing the page when I'm at /admin/hospital/edit redirect me back to /admin
  • Integration tests are failing. Unable to save hospital data
    failed-to-update-hospital
  • Please scroll to the top when we click on "Edit hospital infos" button to let the user see form without needing to scroll up himself.

@SteveGT96 SteveGT96 requested a review from SilverD3 October 14, 2024 09:38
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi merged commit 98d1c48 into informatici:develop Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants