Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OH2-305 | Suppliers create and update #596

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

SilverD3
Copy link
Contributor

The API doesn't provide any endpoint for suppliers deletion, so the delete feature isn't include in this PR.

See OH2-305

@mwithi
Copy link
Member

mwithi commented May 29, 2024

The API doesn't provide any endpoint for suppliers deletion, so the delete feature isn't include in this PR.

for suppliers we have soft-deletion (updateSupplier with SUP_DELETED='Y') I don't know why supDeleted has not been mapped in the DTO, could you open an issue for that in OP project?

@SilverD3
Copy link
Contributor Author

@mwithi There are too many boards in the OP project. In which one should open the issue ?

@mwithi
Copy link
Member

mwithi commented Jun 3, 2024

@mwithi There are too many boards in the OP project. In which one should open the issue ?

this one now has conflict, please I've no time to review all of them, let me ask @SteveGT96

@mwithi mwithi requested a review from SteveGT96 June 3, 2024 14:46
Copy link
Contributor

@SteveGT96 SteveGT96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we are prefixing admin paths with "admin_" and we are reusing defined paths anywhere wanna navigate(navigate(PATHS....)

Please, could you align also ? Could check othe PRs to see.

src/components/accessories/admin/suppliers/Suppliers.tsx Outdated Show resolved Hide resolved
src/consts.ts Outdated Show resolved Hide resolved
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @SteveGT96

@mwithi mwithi merged commit bc434ff into informatici:develop Jun 5, 2024
3 checks passed
@mwithi
Copy link
Member

mwithi commented Jun 5, 2024

Do we need new permissions for the new page?

image

@gasp
Copy link
Contributor

gasp commented Jun 6, 2024

Good catch @mwithi , issuing a fix immediately: #600

@mwithi
Copy link
Member

mwithi commented Jun 7, 2024

@mwithi There are too many boards in the OP project. In which one should open the issue ?

The board is the OH2 Kanban but the issue has already been opened and backend side done, see OH2-310.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants