-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OH2-305 | Suppliers create and update #596
Conversation
for suppliers we have soft-deletion (updateSupplier with SUP_DELETED='Y') I don't know why supDeleted has not been mapped in the DTO, could you open an issue for that in OP project? |
@mwithi There are too many boards in the OP project. In which one should open the issue ? |
this one now has conflict, please I've no time to review all of them, let me ask @SteveGT96 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we are prefixing admin paths with "admin_" and we are reusing defined paths anywhere wanna navigate(navigate(PATHS....)
Please, could you align also ? Could check othe PRs to see.
src/components/accessories/admin/suppliers/editSupplier/EditSupplier.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by @SteveGT96
The board is the OH2 Kanban but the issue has already been opened and backend side done, see OH2-310. |
The API doesn't provide any endpoint for suppliers deletion, so the delete feature isn't include in this PR.
See OH2-305