Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OH2-220 | Add reset button in visit and laboratory filters #498

Merged
merged 8 commits into from
Oct 4, 2023

Conversation

SteveGT96
Copy link
Contributor

@SteveGT96 SteveGT96 commented Jul 19, 2023

See OH2-220.

Also added the reset button in laboratory filter form.

@SteveGT96
Copy link
Contributor Author

Hello @mwithi ! I've also added the reset button in laboratory filter form.

1 similar comment
@SteveGT96
Copy link
Contributor Author

Hello @mwithi ! I've also added the reset button in laboratory filter form.

Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @SteveGT96 it seems that the two filter pages have different l&f: Visits has the filter button on the left, Laboratory on the right. I would make the same, and the RESET button always on the same side (on the left if FILTER is at right-end or viceversa).

Also looks like the two actions behave in different way (see OH2-220)

@mwithi
Copy link
Member

mwithi commented Sep 13, 2023

Up!

@SteveGT96 SteveGT96 requested a review from mwithi September 28, 2023 13:42
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi merged commit 41ba7ab into informatici:develop Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants