Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-1359 | Add missing FK for Auditable entities #1464

Merged
merged 18 commits into from
Jan 8, 2025
Merged

OP-1359 | Add missing FK for Auditable entities #1464

merged 18 commits into from
Jan 8, 2025

Conversation

ArnaudFofou
Copy link
Contributor

@ArnaudFofou ArnaudFofou commented Dec 3, 2024 •
edited by mwithi
Loading

See OP-1359.

@mwithi
Copy link
Member

mwithi commented Dec 7, 2024

Please can you also take the chance to rename these FK? (found with link)

+-------------------+---------------------------+---------------------------+-------------------------------------------------+--------------------------+
| constraint_schema | table_name                | referenced_table_name     | constraint_name                                 | column_name              |
+-------------------+---------------------------+---------------------------+-------------------------------------------------+--------------------------+
| ...                                                                                                                                                    |
| oh                | oh_medicaldsrinventoryrow | oh_medicaldsrinventory    | oh_medicaldsrinventoryrow_ibfk_1                | MINVTR_INVT_ID           |
| oh                | oh_medicaldsrinventoryrow | oh_medicaldsr             | oh_medicaldsrinventoryrow_ibfk_2                | MINVTR_MDSR_ID           |
| oh                | oh_medicaldsrinventoryrow | oh_medicaldsrlot          | oh_medicaldsrinventoryrow_ibfk_3                | MINVTR_LT_ID_A           |
| ...                                                                                                                                                    |
| oh                | oh_patient_consensus      | oh_patient                | oh_patient_consensus_ibfk_1                     | PTC_PAT_ID               |
| ...                                                                                                                                                    |
| oh                | oh_user_settings          | oh_user                   | USS_US_ID_A_FK                                  | USS_US_ID_A              |
| ...                                                                                                                                                    |
+-------------------+---------------------------+---------------------------+-------------------------------------------------+--------------------------+

@mwithi
Copy link
Member

mwithi commented Dec 10, 2024

Waiting #1465 to be merged and tested again

mwithi
mwithi approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM. Thanks a lot!

@mwithi mwithi merged commit 1337aa1 into informatici:develop Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwithi mwithi mwithi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArnaudFofou @mwithi