Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-1043 | Implement soft deletion #496

Merged
merged 18 commits into from
Nov 14, 2024
Merged

OP-1043 | Implement soft deletion #496

merged 18 commits into from
Nov 14, 2024

Conversation

SteveGT96
Copy link
Contributor

@SteveGT96 SteveGT96 commented Oct 30, 2024 •
edited by jira bot
Loading

See OP-1043

dbmalkovsky
dbmalkovsky reviewed Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there no tests exercising the deletion code?

mwithi
mwithi requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests

@mwithi mwithi requested a review from dbmalkovsky November 5, 2024 14:50
dbmalkovsky
dbmalkovsky reviewed Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments.

Also I don't see any new tests for soft deletion especially when the object is not found, and/or already deleted

@SteveGT96 SteveGT96 mentioned this pull request Nov 7, 2024
Merged
@mwithi
Copy link
Member

mwithi commented Nov 13, 2024

please resolve conflicts

@mwithi
Copy link
Member

mwithi commented Nov 13, 2024

I think checks are failing because API and CORE are not equally aligned with develop

mwithi
mwithi approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi merged commit d82effd into informatici:develop Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbmalkovsky dbmalkovsky dbmalkovsky left review comments

@mwithi mwithi mwithi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SteveGT96 @mwithi @dbmalkovsky