-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clippy errors/warnings when upgrading to Rust 1.51 #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
5 tasks
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
=========================================
- Coverage 55.7% 29.3% -26.4%
=========================================
Files 198 194 -4
Lines 14063 10766 -3297
Branches 3692 4444 +752
=========================================
- Hits 7834 3156 -4678
+ Misses 5897 4652 -1245
- Partials 332 2958 +2626
Continue to review full report at Codecov.
|
romac
approved these changes
Mar 25, 2021
thanethomson
added a commit
that referenced
this pull request
Mar 30, 2021
* Rename domain types to comply with Rust API standards Signed-off-by: Thane Thomson <[email protected]> * Fix incorrect enum name Signed-off-by: Thane Thomson <[email protected]> * Fix clippy errors Signed-off-by: Thane Thomson <[email protected]> * Fix more clippy lints Signed-off-by: Thane Thomson <[email protected]> * Add preliminary CHANGELOG Signed-off-by: Thane Thomson <[email protected]> * Fix clippy warnings for tendermint-p2p crate Signed-off-by: Thane Thomson <[email protected]> * Add CHANGELOG links Signed-off-by: Thane Thomson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust's 1.51 release brought with it a number of new clippy errors and warnings. This PR attempts to address the bulk of them.
Unfortunately this results in some breaking changes to data structures' names, because they were improperly named up to now according to Rust's API guidelines.