-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix consensus state vote summary deserialization #837
Conversation
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
========================================
- Coverage 29.1% 29.1% -0.1%
========================================
Files 194 194
Lines 10766 10771 +5
Branches 4443 4448 +5
========================================
- Hits 3139 3135 -4
+ Misses 4653 4651 -2
- Partials 2974 2985 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff :)
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the requested change her was addressed, so I'll provide the green check :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
We might want to revisit this code altogether at some point, perhaps to rewrite it to use parser combinators or something like that as the format is a bit too involved for manual parsing. But in the meantime, with the new tests, we have some confidence that this works as expected and can refactor later.
Ideally we'd avoid this kind of custom serialization format altogether from the server side 😁 It should be something that's encoded properly in JSON/Protobuf, and not a custom string format. |
💯 |
Closes #836