Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent accidental publication of light-client and light-node crates to Crates.io #317

Closed
romac opened this issue Jun 10, 2020 · 1 comment · Fixed by #347
Closed

Prevent accidental publication of light-client and light-node crates to Crates.io #317

romac opened this issue Jun 10, 2020 · 1 comment · Fixed by #347
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@romac
Copy link
Member

romac commented Jun 10, 2020 •
edited
Loading

I think we should add publish = false to the Cargo.toml manifest of both the light-client and light-node crates to prevent accidentally publishing them to Crates.io, since they are not ready to be released yet.
@liamsi liamsi mentioned this issue Jun 19, 2020
Closed
liamsi added a commit that referenced this issue Jun 19, 2020
@liamsi
addresses concerns in #317
54e5231
liamsi added a commit that referenced this issue Jun 19, 2020
@liamsi
Prep v0.14.0 release (#347)
dcd740d 
* addresses concerns in #317

* bump all versions (crates only)

* bump version in CHANGES.md

* Changelog:

 - add summary
 - include references only once to make
 changelog more readable
 - add #343
 - rephrase some
 - consistent refs ([#num])

* self reference

* fix link

* readability

* Update CHANGES.md
@liamsi
Copy link
Member

liamsi commented Jun 19, 2020

done in #347

@liamsi liamsi closed this as completed Jun 19, 2020
@xla xla added dependencies Pull requests that update a dependency file enhancement New feature or request labels Jun 19, 2020
@xla xla linked a pull request Jun 19, 2020 that will close this issue
Prep v0.14.0 release #347
Merged
5 tasks
lklimek pushed a commit to lklimek/tenderdash-abci-rs that referenced this issue Feb 28, 2023
@liamsi
Prep v0.14.0 release (#347)
f153339 
* addresses concerns in informalsystems/tendermint-rs#317

* bump all versions (crates only)

* bump version in CHANGES.md

* Changelog:

 - add summary
 - include references only once to make
 changelog more readable
 - add #343
 - rephrase some
 - consistent refs ([#num])

* self reference

* fix link

* readability

* Update CHANGES.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prep v0.14.0 release informalsystems/tendermint-rs
3 participants
@xla @romac @liamsi