Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup exported types in connection #119

Closed
adizere opened this issue Aug 3, 2020 · 0 comments
Closed

Cleanup exported types in connection #119

adizere opened this issue Aug 3, 2020 · 0 comments
Assignees

Comments

@adizere
Copy link
Contributor

adizere commented Aug 3, 2020

The exported module brings up a related problem I believe. Parts of this module (and its intended functionality) may be unnecessary and we can remove it..

yes, we should remove the traits from the exported.rs files (in both connection and channel folders).

Originally posted by @ancazamfir in informalsystems/hermes#186 (comment)

More specifically, we can remove the traits Connection and ConnectionCounterparty:

https://github.com/informalsystems/ibc-rs/blob/574371a280a282bdfaa1045ca8a6e628d612b79d/modules/src/ics03_connection/exported.rs#L6-L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant