Fix for chain_version parsing when chain identifier has multiple dashes
#884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use expect Co-authored-by: jongwhan lee <[email protected]>
adizere
changed the title
chain_version parsing when chain identifiers has multiple dashes
adizere
changed the title
chain_version parsing when chain identifiers has multiple dasheschain_version parsing when chain identifier has multiple dashes
ancazamfir
approved these changes
May 1, 2021
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…shes (informalsystems#884) * Solution: use the last digit (fix #878) (informalsystems#879) use expect Co-authored-by: jongwhan lee <[email protected]> * Doc tests and FMT * Changelog Co-authored-by: Jongwhan Lee <[email protected]> Co-authored-by: jongwhan lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: jongwhan lee.
This is the continuation of the work from #879.
Closes: cosmos/ibc-rs#80
Description
For contributor use:
docs/) and code comments.Files changedin the Github PR explorer.