Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward NewBlock events to all workers to clear pending packets if needed #733

Merged
merged 6 commits into from
Mar 12, 2021

Conversation

romac
Copy link
Member

@romac romac commented Mar 10, 2021

This is best reviewed one commit after the other.

Description

  • Forward NewBlock events to all workers to clear pending packets if needed.
  • Document the code in supervisor.rs

Tested by following the instructions in https://hermes.informal.systems/tutorial_relay_existing_path.html.


For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac requested a review from ancazamfir March 10, 2021 11:24
@codecov-io
Copy link

Codecov Report

Merging #733 (bc0ecc5) into master (b1b37f5) will increase coverage by 30.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #733      +/-   ##
=========================================
+ Coverage    13.6%   44.1%   +30.4%     
=========================================
  Files          69     156      +87     
  Lines        3752   10356    +6604     
  Branches     1374       0    -1374     
=========================================
+ Hits          513    4572    +4059     
- Misses       2618    5784    +3166     
+ Partials      621       0     -621     
Impacted Files Coverage Δ
...application/ics20_fungible_token_transfer/error.rs 0.0% <ø> (ø)
...ion/ics20_fungible_token_transfer/msgs/transfer.rs 0.0% <ø> (ø)
..._transfer/relay_application_logic/send_transfer.rs 0.0% <ø> (ø)
modules/src/events.rs 0.0% <ø> (ø)
modules/src/handler.rs 100.0% <ø> (ø)
modules/src/ics02_client/client_def.rs 47.3% <ø> (ø)
modules/src/ics02_client/client_type.rs 79.1% <ø> (+31.5%) ⬆️
modules/src/ics02_client/context.rs 100.0% <ø> (ø)
modules/src/ics02_client/error.rs 100.0% <ø> (ø)
modules/src/ics02_client/events.rs 15.7% <ø> (+15.7%) ⬆️
... and 259 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280e03a...bc0ecc5. Read the comment docs.

Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! As we discussed the spawning of workers from chain state scanning will be done in a different PR. Thanks Romain!

@romac romac merged commit ad827a9 into master Mar 12, 2021
@romac romac deleted the romac/new-blocks branch March 12, 2021 16:29
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants