Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct endpoint when logging query error #4249

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Nov 13, 2024

Closes: #4250

Description

Fix error logs in relay_path.rs so that it logs the correct endpoint which failed during a query.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
    • If guide has been updated, tag GitHub user mircea-c
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 requested a review from romac November 13, 2024 15:09
@ljoss17 ljoss17 marked this pull request as ready for review November 14, 2024 07:57
@ljoss17 ljoss17 added this pull request to the merge queue Nov 14, 2024
Merged via the queue into master with commit b279982 Nov 14, 2024
29 checks passed
@ljoss17 ljoss17 deleted the luca_joss/fix-error-logs-in-relay-path branch November 14, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect RPC endpoint in error log
2 participants